Address a corner case with name truncation

Author: amaslenn

src/cloudai/_core/json_gen_strategy.py

@@ -55,13 +55,13 @@ def sanitize_k8s_job_name(self, job_name: str) -> str:
         sanitized_name = job_name.lower()
         sanitized_name = re.sub(r"[^a-z0-9-]", "-", sanitized_name)
         sanitized_name = re.sub(r"^[^a-z0-9]+", "", sanitized_name)
+        sanitized_name = sanitized_name[:253]
         sanitized_name = re.sub(r"[^a-z0-9]+$", "", sanitized_name)
-        final_name = sanitized_name[:253]
 
-        if not final_name:
+        if not sanitized_name:
             raise ValueError(f"'{job_name}' cannot be sanitized to a valid Kubernetes job name.")
 
-        return final_name
+        return sanitized_name
 
     def store_test_run(self) -> None:
         from cloudai.models.scenario import TestRunDetails

tests/json_gen_strategy/test_common_kubernetes.py

@@ -35,6 +35,8 @@ def gen_json(self) -> dict:
         ("name@with#special$chars", "name-with-special-chars"),
         ("NameWithUpperCase", "namewithuppercase"),
         ("a" * 260, "a" * 253),
+        ("---leading-and-trailing---", "leading-and-trailing"),
+        ("a" * 250 + "-" * 3 + "b" * 10, "a" * 250),  # ensure no trailing hyphens on truncation
     ],
 )
 def test_job_name_sanitization(k8s_system: KubernetesSystem, base_tr: TestRun, tname: str, expected: str) -> None: