Skip to content

Commit e3c4f6f

Browse files
greptile suggested unit test
1 parent c005e41 commit e3c4f6f

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

tests/slurm_command_gen_strategy/test_megatron_bridge_slurm_command_gen_strategy.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,20 @@ def test_hf_token_empty_is_rejected_by_schema(self) -> None:
8787
with pytest.raises(Exception, match=r"hf_token"):
8888
MegatronBridgeCmdArgs.model_validate({"hf_token": "", "model_name": "qwen3", "model_size": "30b_a3b"})
8989

90+
@pytest.mark.parametrize("field_name", ["model_name", "model_size"])
91+
def test_model_fields_empty_string_rejected(self, field_name: str) -> None:
92+
data = {"hf_token": "dummy_token", "model_name": "qwen3", "model_size": "30b_a3b"}
93+
data[field_name] = ""
94+
with pytest.raises(Exception, match=field_name):
95+
MegatronBridgeCmdArgs.model_validate(data)
96+
97+
@pytest.mark.parametrize("field_name", ["model_name", "model_size"])
98+
def test_model_fields_whitespace_only_rejected(self, field_name: str) -> None:
99+
data = {"hf_token": "dummy_token", "model_name": "qwen3", "model_size": "30b_a3b"}
100+
data[field_name] = " \t "
101+
with pytest.raises(Exception, match=rf"cmd_args\.{field_name} cannot be empty\."):
102+
MegatronBridgeCmdArgs.model_validate(data)
103+
90104
def test_git_repos_can_pin_megatron_bridge_commit(self) -> None:
91105
args = MegatronBridgeCmdArgs(hf_token="dummy_token", model_name="qwen3", model_size="30b_a3b")
92106
tdef = MegatronBridgeTestDefinition(

0 commit comments

Comments
 (0)