Skip to content

Commit eaba85a

Browse files
authored
Mount huggingface_home_container_path unconditionally (#655)
1 parent d3e2ac2 commit eaba85a

File tree

1 file changed

+5
-18
lines changed

1 file changed

+5
-18
lines changed

src/cloudai/workloads/ai_dynamo/slurm_command_gen_strategy.py

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ def _container_mounts(self) -> list[str]:
3535

3636
mounts = [
3737
f"{dynamo_repo_path}:{dynamo_repo_path}",
38-
f"{td.cmd_args.huggingface_home_host_path}:{td.cmd_args.huggingface_home_container_path}"
39-
if td.cmd_args.dynamo.backend == "vllm"
40-
else f"{td.cmd_args.huggingface_home_host_path}:{td.cmd_args.huggingface_home_host_path}",
38+
f"{td.cmd_args.huggingface_home_host_path}:{td.cmd_args.huggingface_home_container_path}",
4139
f"{td.script.installed_path.absolute()!s}:{td.script.installed_path.absolute()!s}",
4240
]
4341

@@ -73,21 +71,10 @@ def _get_toml_args(self, base_model: BaseModel, prefix: str, exclude: List[str]
7371
return args
7472

7573
def _gen_script_args(self, td: AIDynamoTestDefinition) -> List[str]:
76-
args = []
77-
78-
huggingface_path = (
79-
td.cmd_args.huggingface_home_container_path
80-
if td.cmd_args.dynamo.backend == "vllm"
81-
else td.cmd_args.huggingface_home_host_path
82-
)
83-
args.extend(
84-
[
85-
f"--huggingface-home {huggingface_path}",
86-
"--results-dir /cloudai_run_results",
87-
]
88-
)
89-
90-
# Get base dynamo args first
74+
args = [
75+
f"--huggingface-home {td.cmd_args.huggingface_home_container_path}",
76+
"--results-dir /cloudai_run_results",
77+
]
9178
args.extend(
9279
self._get_toml_args(
9380
td.cmd_args.dynamo, "--dynamo-", exclude=["prefill_worker", "decode_worker", "genai_perf"]

0 commit comments

Comments
 (0)