Skip to content

Commit 5c37654

Browse files
[pre-commit.ci] auto code formatting
1 parent 3906909 commit 5c37654

File tree

4 files changed

+57
-56
lines changed

4 files changed

+57
-56
lines changed

include/cuco/detail/dynamic_map.inl

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -190,40 +190,41 @@ void dynamic_map<Key, Value, Scope, Allocator>::erase(InputIt first,
190190
CUCO_CUDA_TRY(cudaMemset(num_successes_, 0, sizeof(atomic_ctr_type)));
191191

192192
// zero out submap success counters
193-
if(submaps_.size() > 1) {
193+
if (submaps_.size() > 1) {
194194
static_assert(sizeof(std::size_t) == sizeof(atomic_ctr_type));
195-
for(int i = 0; i < submaps_.size(); ++i) {
195+
for (int i = 0; i < submaps_.size(); ++i) {
196196
CUCO_CUDA_TRY(cudaMemset(submap_num_successes_[i], 0, sizeof(atomic_ctr_type)));
197197
}
198198
}
199-
199+
200200
auto const temp_storage_size = submaps_.size() * sizeof(unsigned long long);
201201

202202
detail::erase<block_size, tile_size, cuco::pair_type<key_type, mapped_type>>
203-
<<<grid_size, block_size, temp_storage_size>>>(
204-
first,
205-
first + num_keys,
206-
submap_views_.data().get(),
207-
submap_mutable_views_.data().get(),
208-
num_successes_,
209-
d_submap_num_successes_.data().get(),
210-
submaps_.size(),
211-
hash,
212-
key_equal);
203+
<<<grid_size, block_size, temp_storage_size>>>(first,
204+
first + num_keys,
205+
submap_views_.data().get(),
206+
submap_mutable_views_.data().get(),
207+
num_successes_,
208+
d_submap_num_successes_.data().get(),
209+
submaps_.size(),
210+
hash,
211+
key_equal);
213212

214213
// update total dynamic map size
215214
std::size_t h_num_successes;
216215
CUCO_CUDA_TRY(
217216
cudaMemcpy(&h_num_successes, num_successes_, sizeof(atomic_ctr_type), cudaMemcpyDeviceToHost));
218217
size_ -= h_num_successes;
219-
220-
if(submaps_.size() == 1) {
218+
219+
if (submaps_.size() == 1) {
221220
submaps_[0]->size_ -= h_num_successes;
222221
} else {
223-
for(int i = 0; i < submaps_.size(); ++i) {
222+
for (int i = 0; i < submaps_.size(); ++i) {
224223
std::size_t h_submap_num_successes;
225-
CUCO_CUDA_TRY(cudaMemcpy(
226-
&h_submap_num_successes, submap_num_successes_[i], sizeof(atomic_ctr_type), cudaMemcpyDeviceToHost));
224+
CUCO_CUDA_TRY(cudaMemcpy(&h_submap_num_successes,
225+
submap_num_successes_[i],
226+
sizeof(atomic_ctr_type),
227+
cudaMemcpyDeviceToHost));
227228
submaps_[i]->size_ -= h_submap_num_successes;
228229
}
229230
}

include/cuco/detail/dynamic_map_kernels.cuh

Lines changed: 29 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -203,14 +203,14 @@ __global__ void erase(InputIt first,
203203

204204
std::size_t thread_num_successes = 0;
205205

206-
auto tid = block_size * blockIdx.x + threadIdx.x;
207-
auto it = first + tid;
206+
auto tid = block_size * blockIdx.x + threadIdx.x;
207+
auto it = first + tid;
208208

209-
if(num_submaps > 1) {
210-
for(int i = threadIdx.x; i < num_submaps; i += block_size)
209+
if (num_submaps > 1) {
210+
for (int i = threadIdx.x; i < num_submaps; i += block_size)
211211
submap_block_num_successes[i] = 0;
212212
__syncthreads();
213-
213+
214214
while (it < last) {
215215
int i;
216216
for (i = 0; i < num_submaps; ++i) {
@@ -224,8 +224,7 @@ __global__ void erase(InputIt first,
224224
}
225225
} else {
226226
while (it < last) {
227-
if(submap_mutable_views[0].erase(*it, hash, key_equal))
228-
thread_num_successes++;
227+
if (submap_mutable_views[0].erase(*it, hash, key_equal)) thread_num_successes++;
229228
it += gridDim.x * blockDim.x;
230229
}
231230
}
@@ -235,11 +234,11 @@ __global__ void erase(InputIt first,
235234
num_successes->fetch_add(block_num_successes, cuda::std::memory_order_relaxed);
236235
}
237236

238-
if(num_submaps > 1) {
239-
for(int i = 0; i < num_submaps; ++i) {
240-
if(threadIdx.x == 0) {
241-
submap_num_successes[i]->fetch_add(
242-
static_cast<std::size_t>(submap_block_num_successes[i]), cuda::std::memory_order_relaxed);
237+
if (num_submaps > 1) {
238+
for (int i = 0; i < num_submaps; ++i) {
239+
if (threadIdx.x == 0) {
240+
submap_num_successes[i]->fetch_add(static_cast<std::size_t>(submap_block_num_successes[i]),
241+
cuda::std::memory_order_relaxed);
243242
}
244243
}
245244
}
@@ -255,14 +254,14 @@ template <uint32_t block_size,
255254
typename Hash,
256255
typename KeyEqual>
257256
__global__ void erase(InputIt first,
258-
InputIt last,
259-
viewT* submap_views,
260-
mutableViewT* submap_mutable_views,
261-
atomicT* num_successes,
262-
atomicT** submap_num_successes,
263-
const uint32_t num_submaps,
264-
Hash hash,
265-
KeyEqual key_equal)
257+
InputIt last,
258+
viewT* submap_views,
259+
mutableViewT* submap_mutable_views,
260+
atomicT* num_successes,
261+
atomicT** submap_num_successes,
262+
const uint32_t num_submaps,
263+
Hash hash,
264+
KeyEqual key_equal)
266265
{
267266
typedef cub::BlockReduce<std::size_t, block_size> BlockReduce;
268267
__shared__ typename BlockReduce::TempStorage temp_storage;
@@ -274,13 +273,13 @@ __global__ void erase(InputIt first,
274273
auto tid = block_size * blockIdx.x + threadIdx.x;
275274
auto it = first + tid / tile_size;
276275

277-
if(num_submaps > 1) {
278-
for(int i = threadIdx.x; i < num_submaps; i += block_size)
276+
if (num_submaps > 1) {
277+
for (int i = threadIdx.x; i < num_submaps; i += block_size)
279278
submap_block_num_successes[i] = 0;
280279
__syncthreads();
281-
280+
282281
while (it < last) {
283-
auto erased = false;
282+
auto erased = false;
284283
int i;
285284
for (i = 0; i < num_submaps; ++i) {
286285
erased = submap_mutable_views[i].erase(tile, *it, hash, key_equal);
@@ -295,8 +294,7 @@ __global__ void erase(InputIt first,
295294
} else {
296295
while (it < last) {
297296
auto erased = submap_mutable_views[0].erase(tile, *it, hash, key_equal);
298-
if (erased && tile.thread_rank() == 0)
299-
thread_num_successes++;
297+
if (erased && tile.thread_rank() == 0) thread_num_successes++;
300298

301299
it += (gridDim.x * blockDim.x) / tile_size;
302300
}
@@ -307,11 +305,11 @@ __global__ void erase(InputIt first,
307305
num_successes->fetch_add(block_num_successes, cuda::std::memory_order_relaxed);
308306
}
309307

310-
if(num_submaps > 1) {
311-
for(int i = 0; i < num_submaps; ++i) {
312-
if(threadIdx.x == 0) {
313-
submap_num_successes[i]->fetch_add(
314-
static_cast<std::size_t>(submap_block_num_successes[i]), cuda::std::memory_order_relaxed);
308+
if (num_submaps > 1) {
309+
for (int i = 0; i < num_submaps; ++i) {
310+
if (threadIdx.x == 0) {
311+
submap_num_successes[i]->fetch_add(static_cast<std::size_t>(submap_block_num_successes[i]),
312+
cuda::std::memory_order_relaxed);
315313
}
316314
}
317315
}

include/cuco/dynamic_map.cuh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818

1919
#include <cooperative_groups.h>
2020
#include <cub/cub.cuh>
21+
#include <cuco/detail/dynamic_map_kernels.cuh>
2122
#include <cuco/detail/error.hpp>
2223
#include <cuco/static_map.cuh>
2324
#include <cuda/std/atomic>
24-
#include <cuco/detail/dynamic_map_kernels.cuh>
2525
#include <thrust/device_vector.h>
2626

2727
namespace cuco {
@@ -277,8 +277,9 @@ class dynamic_map {
277277
submap_mutable_views_; ///< vector of mutable device views for each submap
278278
std::size_t min_insert_size_{}; ///< min remaining capacity of submap for insert
279279
atomic_ctr_type* num_successes_; ///< number of successfully inserted keys on insert
280-
std::vector<atomic_ctr_type*> submap_num_successes_; ///< number of succesfully erased keys for each submap
281-
thrust::device_vector<atomic_ctr_type*> d_submap_num_successes_;
280+
std::vector<atomic_ctr_type*>
281+
submap_num_successes_; ///< number of succesfully erased keys for each submap
282+
thrust::device_vector<atomic_ctr_type*> d_submap_num_successes_;
282283
Allocator alloc_{}; ///< Allocator passed to submaps to allocate their device storage
283284
counter_allocator_type counter_allocator_{}; ///< Allocator used to allocate `num_successes_`
284285
};

tests/dynamic_map/erase_test.cu

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,9 @@ TEMPLATE_TEST_CASE_SIG("erase key", "", ((typename T), T), (int32_t))
107107
map.insert(pairs_begin2, pairs_begin2 + 4 * num_keys);
108108

109109
// map should resize twice if the erased slots are successfully reused
110-
REQUIRE(map.get_capacity() == 8*num_keys);
110+
REQUIRE(map.get_capacity() == 8 * num_keys);
111111
// check that keys can be successfully deleted from only the first and second submaps
112-
map.erase(d_keys2.begin(), d_keys2.begin() + 2*num_keys);
112+
map.erase(d_keys2.begin(), d_keys2.begin() + 2 * num_keys);
113113
map.contains(d_keys2.begin(), d_keys2.end(), d_keys_exist2.begin());
114114

115115
REQUIRE(cuco::test::none_of(d_keys_exist2.begin(),
@@ -120,8 +120,9 @@ TEMPLATE_TEST_CASE_SIG("erase key", "", ((typename T), T), (int32_t))
120120
d_keys_exist2.end(),
121121
[] __device__(const bool key_found) { return key_found; }));
122122

123-
REQUIRE(map.get_size() == 2*num_keys);
124-
// check that keys can be successfully deleted from all submaps (some will be unsuccessful erases)
123+
REQUIRE(map.get_size() == 2 * num_keys);
124+
// check that keys can be successfully deleted from all submaps (some will be unsuccessful
125+
// erases)
125126
map.erase(d_keys2.begin(), d_keys2.end());
126127

127128
map.contains(d_keys2.begin(), d_keys2.end(), d_keys_exist2.begin());

0 commit comments

Comments
 (0)