Erase Functionality for dynamic_map #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Nicolas-Iskos
changed the title
Nicolas-Iskos
changed the title
Nicolas-Iskos
force-pushed
the
dynamic_map_erase
branch
from
5c37654 to
e01978b
Compare
Nicolas-Iskos
changed the title
Member
|
add to allowlist |
Nicolas-Iskos
force-pushed
the
dynamic_map_erase
branch
from
ebd43eb to
faf8224
Compare
Member
|
@Nicolas-Iskos Can you please check the doxygen warnings here (in the |
PointKernel
requested changes
Sep 1, 2022
Member
PointKernel
left a comment
PointKernel
left a comment
There was a problem hiding this comment.
The first round of review.
sleeepyjack
reviewed
Nov 2, 2022
…comments and add erase_none and search_none benchmarks
… and erase_none benchmarks and get rid of sentinel namespace
…nd async instructions when possible
Member
|
rerun tests |
PointKernel
reviewed
Dec 20, 2022
…ect, constexpr when possible
PointKernel
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erase support added for
cuco::dynamic_map, based oncuco::static_mapwith erase support. See #142. More details to follow soon.Some benchmark data: