Skip to content

Remove fmtheaders from CUDA-Q internal headers #3642

@sacpis

Description

@sacpis

Required prerequisites

  • Search the issue tracker to check if your feature has already been mentioned or rejected in other issues.

Describe the feature

From @amccaskey
The big issue here is that Logger.h is a common header for downstream libraries (so they can get cudaq::info()) and it has FmtCore.h as an include. The changes here do not change that. The real fix is to remove any fmtlib headers from our own headers and hide them in cpp implementation code. I'm not sure how one would do that and keep cudaq::info() variadic though.

Please see comment on the PR #3014.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions