fix(chart): normalize mqtt stream sources (#29)

Render empty source transform destinations explicitly.

This matches the Stream specs that NACK writes back in control-loop mode.

Keep the NACK control loop enabled.

Signed-off-by: Frank Spitulski <fspitulski@nvidia.com>

Author: FrankSpitulski

deploy/nats-event-bus/templates/mqtt-streams.yaml

@@ -36,6 +36,7 @@ spec:
       subjectTransforms:
         {{- range $crossLayer.cscExports }}
         - source: {{ printf "$MQTT.msgs.%s" . | quote }}
+          dest: "" {{- /* NACK persists omitted destinations this way; keep SSA aligned. */}}
         {{- end }}
         {{- range $crossLayer.cscPrefixedExports }}
         - source: {{ printf "$MQTT.msgs.cpc.%s.%s" $clusterId . | quote }}
@@ -70,6 +71,7 @@ spec:
       subjectTransforms:
         {{- range $crossLayer.cscExports }}
         - source: {{ printf "$MQTT.rmsgs.%s" . | quote }}
+          dest: "" {{- /* NACK persists omitted destinations this way; keep SSA aligned. */}}
         {{- end }}
         {{- range $crossLayer.cscPrefixedExports }}
         - source: {{ printf "$MQTT.rmsgs.cpc.%s.%s" $clusterId . | quote }}

local/nats/deploy.sh

@@ -404,9 +404,8 @@ else
   VALUES_FILES="${VALUES_FILES} -f ${SCRIPT_DIR}/k8s/${cluster}/values.yaml"
 fi
 
-# TODO: Investigate nack jetstream-controller taking ownership of .spec.sources via Update
-# This causes server-side apply conflicts with Helm. Using --force-conflicts as workaround.
-# See: https://github.com/nats-io/nack
+# Keep force-conflicts for source/topology changes where NACK control-loop mode
+# owns existing Stream source fields.
 helm upgrade --install nats-event-bus "${CHART_DIR}" \
   --namespace ${namespace} \
   ${VALUES_FILES} \