Merge pull request #2629 from NVIDIA/bump-nfd

tariq1890 · web-flow · commit 17c080860692 · 2026-07-13T10:14:19.000-07:00
bump node-feature-discovery to v0.19.0
diff --git a/deployments/gpu-operator/Chart.lock b/deployments/gpu-operator/Chart.lock
@@ -1,6 +1,6 @@
 dependencies:
 - name: node-feature-discovery
   repository: oci://registry.k8s.io/nfd/charts
-  version: 0.18.3
-digest: sha256:1bce3b80da1e6d47a0befbaa6a2f758aeac6d20382e900f0c301f45020afbebc
-generated: "2026-01-23T15:08:56.617442-08:00"
+  version: 0.19.0
+digest: sha256:74a6bc356f75fdeef2541cb01b8fd49b40daff296b26b44e077ff70d4f2f9fad
+generated: "2026-07-13T08:59:51.650411-07:00"
diff --git a/deployments/gpu-operator/Chart.yaml b/deployments/gpu-operator/Chart.yaml
@@ -19,6 +19,6 @@ keywords:
 
 dependencies:
   - name: node-feature-discovery
-    version: 0.18.3
+    version: 0.19.0
     repository: oci://registry.k8s.io/nfd/charts
     condition: nfd.enabled
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/.helmignore b/deployments/gpu-operator/charts/node-feature-discovery/.helmignore
@@ -21,3 +21,8 @@
 .idea/
 *.tmproj
 .vscode/
+# Sources for autogeneration
+README.md.gotmpl
+_metadata.gotmpl
+_metadata-site.gotmpl
+_templates.gotmpl
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/.schema.yaml b/deployments/gpu-operator/charts/node-feature-discovery/.schema.yaml
@@ -0,0 +1,10 @@
+# Configuration file for https://github.com/losisin/helm-values-schema-json
+values:
+  - values.yaml
+output: values.schema.json
+k8sSchemaVersion: "v1.34.1"
+useHelmDocs: true
+# Bundle external $ref schemas into $defs to support air-gapped environments
+# See: https://github.com/kubernetes-sigs/node-feature-discovery/issues/2398
+bundle: true
+bundleWithoutID: true
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/Chart.yaml b/deployments/gpu-operator/charts/node-feature-discovery/Chart.yaml
@@ -1,9 +1,11 @@
 apiVersion: v2
-appVersion: v0.18.3
-description: 'Detects hardware features available on each node in a Kubernetes cluster,
-  and advertises those features using node labels. '
+appVersion: v0.19.0
+description: 'Node Feature Discovery (NFD) is a Kubernetes add-on for detecting hardware
+  features and system configuration. Detected features are advertised as node labels.
+  NFD provides flexible configuration and extension points for a wide range of vendor
+  and application specific node labeling needs. '
 home: https://github.com/kubernetes-sigs/node-feature-discovery
-icon: https://kubernetes-sigs.github.io/node-feature-discovery/v0.18/assets/images/nfd/favicon.svg
+icon: https://kubernetes-sigs.github.io/node-feature-discovery/v0.19/assets/images/nfd/favicon.svg
 keywords:
 - feature-discovery
 - feature-detection
@@ -12,4 +14,4 @@ name: node-feature-discovery
 sources:
 - https://github.com/kubernetes-sigs/node-feature-discovery
 type: application
-version: 0.18.3
+version: 0.19.0
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/README.md b/deployments/gpu-operator/charts/node-feature-discovery/README.md
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/clusterrole.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/clusterrole.yaml
@@ -57,6 +57,25 @@ rules:
   - update
 {{- end }}
 
+{{- if and .Values.worker.enable .Values.worker.rbac.create }}
+{{- if has "node" .Values.worker.ownerRefs }}
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: {{ include "node-feature-discovery.fullname" . }}-worker
+  labels:
+    {{- include "node-feature-discovery.labels" . | nindent 4 }}
+rules:
+- apiGroups:
+  - ""
+  resources:
+  - nodes
+  verbs:
+  - get
+{{- end }}
+{{- end }}
+
 {{- if and .Values.topologyUpdater.enable .Values.topologyUpdater.rbac.create }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1
@@ -82,7 +101,7 @@ rules:
 - apiGroups:
     - ""
   resources:
-    - nodes/proxy
+    - nodes/configz
   verbs:
     - get
 - apiGroups:
@@ -91,6 +110,8 @@ rules:
   - pods
   verbs:
   - get
+  - list
+  - watch
 - apiGroups:
   - topology.node.k8s.io
   resources:
@@ -99,6 +120,14 @@ rules:
   - create
   - get
   - update
+- apiGroups:
+  - apiextensions.k8s.io
+  resources:
+  - customresourcedefinitions
+  verbs:
+  - get
+  - list
+  - watch
 {{- end }}
 
 {{- if and .Values.gc.enable .Values.gc.rbac.create }}
@@ -117,12 +146,6 @@ rules:
   verbs:
   - list
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - nodes/proxy
-  verbs:
-  - get
 - apiGroups:
   - topology.node.k8s.io
   resources:
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/clusterrolebinding.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/clusterrolebinding.yaml
@@ -15,6 +15,26 @@ subjects:
   namespace: {{ include "node-feature-discovery.namespace" .  }}
 {{- end }}
 
+{{- if and .Values.worker.enable .Values.worker.rbac.create }}
+{{- if has "node" .Values.worker.ownerRefs }}
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+  name: {{ include "node-feature-discovery.fullname" . }}-worker
+  labels:
+    {{- include "node-feature-discovery.labels" . | nindent 4 }}
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: {{ include "node-feature-discovery.fullname" . }}-worker
+subjects:
+- kind: ServiceAccount
+  name: {{ include "node-feature-discovery.worker.serviceAccountName" . }}
+  namespace: {{ include "node-feature-discovery.namespace" .  }}
+{{- end }}
+{{- end }}
+
 {{- if and .Values.topologyUpdater.enable .Values.topologyUpdater.rbac.create }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/master-networkpolicy.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/master-networkpolicy.yaml
@@ -0,0 +1,26 @@
+{{- if .Values.master.networkPolicy.enabled }}
+apiVersion: networking.k8s.io/v1
+kind: NetworkPolicy
+metadata:
+  name: {{ template "node-feature-discovery.fullname" . }}-master-network-policy
+  namespace: {{ include "node-feature-discovery.namespace" . }}
+  labels:
+    {{- include "node-feature-discovery.labels" . | nindent 4 }}
+    role: master
+spec:
+  egress:
+    {{- with .Values.master.networkPolicy.egress }}
+      {{- toYaml . | nindent 4 }}
+    {{- end }}
+  ingress:
+    {{- with .Values.master.networkPolicy.ingress }}
+      {{- toYaml . | nindent 4 }}
+    {{- end }}
+  podSelector:
+    matchLabels:
+      {{- include "node-feature-discovery.selectorLabels" . | nindent 6 }}
+      role: master
+  policyTypes:
+  - Egress
+  - Ingress
+{{- end }}
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/master.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/master.yaml
@@ -22,9 +22,16 @@ spec:
     metadata:
       labels:
         {{- include "node-feature-discovery.selectorLabels" . | nindent 8 }}
+        {{- with .Values.master.labels }}
+        {{- toYaml . | nindent 8 }}
+        {{- end }}
         role: master
       annotations:
+        {{- if .Values.checksumValuesOnly }}
+        checksum/config: {{ .Values.master.config | toYaml | sha256sum }}
+        {{- else }}
         checksum/config: {{ include (print $.Template.BasePath "/nfd-master-conf.yaml") . | sha256sum }}
+        {{- end }}
         {{- with .Values.master.annotations }}
         {{- toYaml . | nindent 8 }}
         {{- end }}
@@ -39,6 +46,13 @@ spec:
       securityContext:
         {{- toYaml .Values.master.podSecurityContext | nindent 8 }}
       hostNetwork: {{ .Values.master.hostNetwork }}
+      {{- if kindIs "bool" .Values.master.hostUsers }}
+      hostUsers: {{ .Values.master.hostUsers }}
+      {{- end }}
+      {{- with .Values.master.initContainers }}
+      initContainers:
+        {{- toYaml . | nindent 8 }}
+      {{- end }}
       containers:
         - name: master
           securityContext:
@@ -115,7 +129,9 @@ spec:
             {{- if .Values.master.instance | empty | not }}
             - "-instance={{ .Values.master.instance }}"
             {{- end }}
+            {{- if gt (int .Values.master.replicaCount) 1 }}
             - "-enable-leader-election"
+            {{- end }}
             {{- if .Values.master.extraLabelNs | empty | not }}
             - "-extra-label-ns={{- join "," .Values.master.extraLabelNs }}"
             {{- end }}
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/nfd-gc-networkpolicy.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/nfd-gc-networkpolicy.yaml
@@ -0,0 +1,26 @@
+{{- if .Values.gc.networkPolicy.enabled }}
+apiVersion: networking.k8s.io/v1
+kind: NetworkPolicy
+metadata:
+  name: {{ template "node-feature-discovery.fullname" . }}-gc-network-policy
+  namespace: {{ include "node-feature-discovery.namespace" . }}
+  labels:
+    {{- include "node-feature-discovery.labels" . | nindent 4 }}
+    role: gc
+spec:
+  egress:
+    {{- with .Values.gc.networkPolicy.egress }}
+      {{- toYaml . | nindent 4 }}
+    {{- end }}
+  ingress:
+    {{- with .Values.gc.networkPolicy.ingress }}
+      {{- toYaml . | nindent 4 }}
+    {{- end }}
+  podSelector:
+    matchLabels:
+      {{- include "node-feature-discovery.selectorLabels" . | nindent 6 }}
+      role: gc
+  policyTypes:
+  - Egress
+  - Ingress
+{{- end }}
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/nfd-gc.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/nfd-gc.yaml
@@ -22,6 +22,9 @@ spec:
     metadata:
       labels:
         {{- include "node-feature-discovery.selectorLabels" . | nindent 8 }}
+        {{- with .Values.gc.labels }}
+        {{- toYaml . | nindent 8 }}
+        {{- end }}
         role: gc
       {{- with .Values.gc.annotations }}
       annotations:
@@ -37,6 +40,13 @@ spec:
       securityContext:
         {{- toYaml .Values.gc.podSecurityContext | nindent 8 }}
       hostNetwork: {{ .Values.gc.hostNetwork }}
+      {{- if kindIs "bool" .Values.gc.hostUsers }}
+      hostUsers: {{ .Values.gc.hostUsers }}
+      {{- end }}
+      {{- with .Values.gc.initContainers }}
+      initContainers:
+        {{- toYaml . | nindent 8 }}
+      {{- end }}
       containers:
       - name: gc
         image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/post-delete-job.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/post-delete-job.yaml
@@ -60,6 +60,7 @@ metadata:
     "helm.sh/hook": post-delete
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
 spec:
+  ttlSecondsAfterFinished: 3600
   template:
     metadata:
       labels:
@@ -81,6 +82,10 @@ spec:
             {{- if .Values.master.instance | empty | not }}
             - "-instance={{ .Values.master.instance }}"
             {{- end }}
+          {{- with .Values.master.resources }}
+          resources:
+            {{- toYaml . | nindent 12 }}
+          {{- end }}
       restartPolicy: Never
       {{- with .Values.master.nodeSelector }}
       nodeSelector:
@@ -94,9 +99,4 @@ spec:
       tolerations:
         {{- toYaml . | nindent 8 }}
       {{- end }}
-      {{- with .Values.master.resources }}
-      resources:
-        {{- toYaml . | nindent 8 }}
-      {{- end }}
 {{- end }}
-
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/topologyupdater-networkpolicy.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/topologyupdater-networkpolicy.yaml
@@ -0,0 +1,26 @@
+{{- if .Values.topologyUpdater.networkPolicy.enabled }}
+apiVersion: networking.k8s.io/v1
+kind: NetworkPolicy
+metadata:
+  name: {{ template "node-feature-discovery.fullname" . }}-topology-updater-network-policy
+  namespace: {{ include "node-feature-discovery.namespace" . }}
+  labels:
+    {{- include "node-feature-discovery.labels" . | nindent 4 }}
+    role: topology-updater
+spec:
+  egress:
+    {{- with .Values.topologyUpdater.networkPolicy.egress }}
+      {{- toYaml . | nindent 4 }}
+    {{- end }}
+  ingress:
+    {{- with .Values.topologyUpdater.networkPolicy.ingress }}
+      {{- toYaml . | nindent 4 }}
+    {{- end }}
+  podSelector:
+    matchLabels:
+      {{- include "node-feature-discovery.selectorLabels" . | nindent 6 }}
+      role: topology-updater
+  policyTypes:
+  - Egress
+  - Ingress
+{{- end }}
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/topologyupdater.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/topologyupdater.yaml
@@ -21,9 +21,16 @@ spec:
     metadata:
       labels:
         {{- include "node-feature-discovery.selectorLabels" . | nindent 8 }}
+        {{- with .Values.topologyUpdater.labels }}
+        {{- toYaml . | nindent 8 }}
+        {{- end }}
         role: topology-updater
       annotations:
+        {{- if .Values.checksumValuesOnly }}
+        checksum/config: {{ .Values.topologyUpdater.config | toYaml | sha256sum }}
+        {{- else }}
         checksum/config: {{ include (print $.Template.BasePath "/nfd-topologyupdater-conf.yaml") . | sha256sum }}
+        {{- end }}
         {{- with .Values.topologyUpdater.annotations }}
         {{- toYaml . | nindent 8 }}
         {{- end }}
@@ -37,6 +44,13 @@ spec:
       securityContext:
         {{- toYaml .Values.topologyUpdater.podSecurityContext | nindent 8 }}
       hostNetwork: {{ .Values.topologyUpdater.hostNetwork }}
+      {{- if kindIs "bool" .Values.topologyUpdater.hostUsers }}
+      hostUsers: {{ .Values.topologyUpdater.hostUsers }}
+      {{- end }}
+      {{- with .Values.topologyUpdater.initContainers }}
+      initContainers:
+        {{- toYaml . | nindent 8 }}
+      {{- end }}
       containers:
       - name: topology-updater
         image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/worker-networkpolicy.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/worker-networkpolicy.yaml
@@ -0,0 +1,26 @@
+{{- if .Values.worker.networkPolicy.enabled }}
+apiVersion: networking.k8s.io/v1
+kind: NetworkPolicy
+metadata:
+  name: {{ template "node-feature-discovery.fullname" . }}-worker-network-policy
+  namespace: {{ include "node-feature-discovery.namespace" . }}
+  labels:
+    {{- include "node-feature-discovery.labels" . | nindent 4 }}
+    role: worker
+spec:
+  egress:
+    {{- with .Values.worker.networkPolicy.egress }}
+      {{- toYaml . | nindent 4 }}
+    {{- end }}
+  ingress:
+    {{- with .Values.worker.networkPolicy.ingress }}
+      {{- toYaml . | nindent 4 }}
+    {{- end }}
+  podSelector:
+    matchLabels:
+      {{- include "node-feature-discovery.selectorLabels" . | nindent 6 }}
+      role: worker
+  policyTypes:
+  - Egress
+  - Ingress
+{{- end }}
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/templates/worker.yaml b/deployments/gpu-operator/charts/node-feature-discovery/templates/worker.yaml
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/values.schema.json b/deployments/gpu-operator/charts/node-feature-discovery/values.schema.json
diff --git a/deployments/gpu-operator/charts/node-feature-discovery/values.yaml b/deployments/gpu-operator/charts/node-feature-discovery/values.yaml
