Skip to content

Commit 8d3997c

Browse files
Remove dynamic config
Signed-off-by: aadvani <aadvani@nvidia.com>
1 parent 7c8ecc6 commit 8d3997c

5 files changed

Lines changed: 0 additions & 27 deletions

File tree

crates/api-core/src/dynamic_settings.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ pub struct DynamicSettings {
4545

4646
/// Log stream used to feed the admin web UI.
4747
pub log_stream: crate::logging::stream::LogStream,
48-
49-
/// Restart OVS on DPU agents when admin network configuration changes
50-
pub restart_ovs_on_use_admin_network_change: Arc<AtomicBool>,
5148
}
5249

5350
/// How often to check if the log filter (RUST_LOG) needs resetting

crates/api-core/src/handlers/api.rs

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -177,21 +177,6 @@ pub(crate) fn set_dynamic_config(
177177
.tracing_enabled
178178
.store(enable, Ordering::Relaxed);
179179
}
180-
rpc::ConfigSetting::RestartOvsOnUseAdminNetworkChange => {
181-
let enable = req.value.parse().map_err(|_| {
182-
CarbideError::InvalidArgument(format!(
183-
"Expected bool for RestartOvsOnUseAdminNetworkChange, got {}",
184-
&req.value
185-
))
186-
})?;
187-
api.dynamic_settings
188-
.restart_ovs_on_use_admin_network_change
189-
.store(enable, Ordering::Relaxed);
190-
tracing::info!(
191-
"restart_ovs_on_use_admin_network_change updated to '{}'",
192-
req.value
193-
);
194-
}
195180
}
196181
Ok(Response::new(()))
197182
}

crates/api-core/src/run.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,6 @@ pub async fn run(
170170
bmc_proxy: carbide_config.site_explorer.bmc_proxy.clone(),
171171
tracing_enabled: tconf.tracing_enabled,
172172
log_stream: tconf.log_stream,
173-
restart_ovs_on_use_admin_network_change: carbide_config
174-
.site_explorer
175-
.restart_ovs_on_use_admin_network_change
176-
.clone(),
177173
};
178174
dynamic_settings.start_reset_task(
179175
&mut join_set,

crates/api-core/src/test_support/builder.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,10 +222,6 @@ impl TestApiBuilder {
222222
create_machines: runtime_config.site_explorer.create_machines.clone(),
223223
bmc_proxy: runtime_config.site_explorer.bmc_proxy.clone(),
224224
tracing_enabled: Arc::new(runtime_config.tracing.enabled.into()),
225-
restart_ovs_on_use_admin_network_change: runtime_config
226-
.site_explorer
227-
.restart_ovs_on_use_admin_network_change
228-
.clone(),
229225
log_stream: Default::default(),
230226
};
231227

crates/rpc/proto/forge.proto

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5333,7 +5333,6 @@ enum ConfigSetting {
53335333
BMC_PROXY = 2;
53345334
TRACING_ENABLED = 3;
53355335
SITE_EXPLORER_ENABLED = 4;
5336-
RESTART_OVS_ON_USE_ADMIN_NETWORK_CHANGE = 5;
53375336
}
53385337

53395338
message FindIpAddressRequest {

0 commit comments

Comments
 (0)