Skip to content

Commit f4d7e99

Browse files
docs(rm): document why nvmllib is stored on health checker struct
Address reviewer question about why the NVML interface is duplicated on the health checker rather than accessed via nvmlResourceManager. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
1 parent ca95a90 commit f4d7e99

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

internal/rm/health.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ const (
4242
)
4343

4444
type nvmlDeviceHealthChecker struct {
45+
// nvmllib is the NVML interface used to query device handles during event
46+
// monitoring. Stored here rather than accessed via nvmlResourceManager to
47+
// keep the health checker decoupled and independently testable.
4548
nvmllib nvml.Interface
4649
devices Devices
4750
parentToDeviceMap map[string]*Device

0 commit comments

Comments
 (0)