Skip to content

Commit 612a5b3

Browse files
Add label app:nvidia-dra-driver-gpu to all project components
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
1 parent 3613b76 commit 612a5b3

File tree

12 files changed

+42
-3
lines changed

12 files changed

+42
-3
lines changed

cmd/compute-domain-controller/controller.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ import (
2929
// It contains essential fields for driver identification, Kubernetes client access,
3030
// and work queue management.
3131
type ManagerConfig struct {
32+
// chartName is the Helm chart name to use for the app label value
33+
chartName string
34+
3235
// driverName is the unique identifier for this DRA driver
3336
driverName string
3437

@@ -63,6 +66,7 @@ func (c *Controller) Run(ctx context.Context) error {
6366
workQueue := workqueue.New(workqueue.DefaultControllerRateLimiter())
6467

6568
managerConfig := &ManagerConfig{
69+
chartName: c.config.flags.chartName,
6670
driverName: c.config.driverName,
6771
driverNamespace: c.config.flags.namespace,
6872
imageName: c.config.flags.imageName,

cmd/compute-domain-controller/daemonset.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ type DaemonSetTemplateData struct {
4747
Finalizer string
4848
ComputeDomainLabelKey string
4949
ComputeDomainLabelValue types.UID
50+
AppLabelValue string
5051
ResourceClaimTemplateName string
5152
ImageName string
5253
}
@@ -180,6 +181,7 @@ func (m *DaemonSetManager) Create(ctx context.Context, namespace string, cd *nva
180181
Finalizer: computeDomainFinalizer,
181182
ComputeDomainLabelKey: computeDomainLabelKey,
182183
ComputeDomainLabelValue: cd.UID,
184+
AppLabelValue: m.config.chartName,
183185
ResourceClaimTemplateName: rct.Name,
184186
ImageName: m.config.imageName,
185187
}

cmd/compute-domain-controller/main.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ type Flags struct {
5353
podName string
5454
namespace string
5555
imageName string
56+
chartName string
5657

5758
httpEndpoint string
5859
metricsPath string
@@ -99,6 +100,14 @@ func newApp() *cli.App {
99100
Destination: &flags.imageName,
100101
EnvVars: []string{"IMAGE_NAME"},
101102
},
103+
&cli.StringFlag{
104+
Name: "chart-name",
105+
Usage: "The Helm chart name to use for the app label value.",
106+
Required: true,
107+
Destination: &flags.chartName,
108+
Value: "nvidia-dra-driver-gpu",
109+
EnvVars: []string{"HELM_CHART_NAME"},
110+
},
102111
&cli.StringFlag{
103112
Category: "HTTP server:",
104113
Name: "http-endpoint",

cmd/compute-domain-controller/resourceclaimtemplate.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ type ResourceClaimTemplateTemplateData struct {
4949
Finalizer string
5050
ComputeDomainLabelKey string
5151
ComputeDomainLabelValue types.UID
52+
AppLabelValue string
5253
TargetLabelKey string
5354
TargetLabelValue string
5455
DeviceClassName string
@@ -298,6 +299,7 @@ func (m *DaemonSetResourceClaimTemplateManager) Create(ctx context.Context, name
298299
Finalizer: computeDomainFinalizer,
299300
ComputeDomainLabelKey: computeDomainLabelKey,
300301
ComputeDomainLabelValue: cd.UID,
302+
AppLabelValue: m.config.chartName,
301303
TargetLabelKey: computeDomainResourceClaimTemplateTargetLabelKey,
302304
TargetLabelValue: computeDomainResourceClaimTemplateTargetDaemon,
303305
DeviceClassName: computeDomainDaemonDeviceClass,
@@ -356,6 +358,7 @@ func (m *WorkloadResourceClaimTemplateManager) Create(ctx context.Context, names
356358
Namespace: namespace,
357359
Name: name,
358360
Finalizer: computeDomainFinalizer,
361+
AppLabelValue: m.config.chartName,
359362
ComputeDomainLabelKey: computeDomainLabelKey,
360363
ComputeDomainLabelValue: cd.UID,
361364
TargetLabelKey: computeDomainResourceClaimTemplateTargetLabelKey,

cmd/gpu-kubelet-plugin/main.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ type Flags struct {
4848
hostDriverRoot string
4949
nvidiaCTKPath string
5050
imageName string
51+
chartName string
5152
}
5253

5354
type Config struct {
@@ -117,6 +118,14 @@ func newApp() *cli.App {
117118
Destination: &flags.imageName,
118119
EnvVars: []string{"IMAGE_NAME"},
119120
},
121+
&cli.StringFlag{
122+
Name: "chart-name",
123+
Usage: "The Helm chart name to use for the app label value.",
124+
Required: true,
125+
Destination: &flags.chartName,
126+
Value: "nvidia-dra-driver-gpu",
127+
EnvVars: []string{"HELM_CHART_NAME"},
128+
},
120129
}
121130
cliFlags = append(cliFlags, flags.kubeClientConfig.Flags()...)
122131
cliFlags = append(cliFlags, flags.loggingConfig.Flags()...)

cmd/gpu-kubelet-plugin/sharing.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ type MpsControlDaemonTemplateData struct {
8585
NodeName string
8686
MpsControlDaemonNamespace string
8787
MpsControlDaemonName string
88+
AppLabelValue string
8889
CUDA_VISIBLE_DEVICES string //nolint:stylecheck
8990
DefaultActiveThreadPercentage string
9091
DefaultPinnedDeviceMemoryLimits map[string]string
@@ -200,6 +201,7 @@ func (m *MpsControlDaemon) Start(ctx context.Context, config *configapi.MpsConfi
200201
NodeName: m.nodeName,
201202
MpsControlDaemonNamespace: m.namespace,
202203
MpsControlDaemonName: m.name,
204+
AppLabelValue: m.manager.config.flags.chartName,
203205
CUDA_VISIBLE_DEVICES: strings.Join(deviceUUIDs, ","),
204206
DefaultActiveThreadPercentage: "",
205207
DefaultPinnedDeviceMemoryLimits: nil,

deployments/helm/nvidia-dra-driver-gpu/templates/controller.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ metadata:
2020
name: {{ include "nvidia-dra-driver-gpu.name" . }}-controller
2121
namespace: {{ include "nvidia-dra-driver-gpu.namespace" . }}
2222
labels:
23+
app: {{ .Chart.Name }}
2324
{{- include "nvidia-dra-driver-gpu.labels" . | nindent 4 }}
2425
spec:
2526
replicas: 1
@@ -66,6 +67,8 @@ spec:
6667
fieldPath: metadata.namespace
6768
- name: IMAGE_NAME
6869
value: {{ include "nvidia-dra-driver-gpu.fullimage" . }}
70+
- name: HELM_CHART_NAME
71+
value: {{ .Chart.Name }}
6972
{{- with .Values.controller.nodeSelector }}
7073
nodeSelector:
7174
{{- toYaml . | nindent 8 }}

deployments/helm/nvidia-dra-driver-gpu/templates/kubeletplugin.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ metadata:
2020
name: {{ include "nvidia-dra-driver-gpu.name" . }}-kubelet-plugin
2121
namespace: {{ include "nvidia-dra-driver-gpu.namespace" . }}
2222
labels:
23+
app: {{ .Chart.Name }}
2324
{{- include "nvidia-dra-driver-gpu.labels" . | nindent 4 }}
2425
spec:
2526
selector:
@@ -72,6 +73,8 @@ spec:
7273
resources:
7374
{{- toYaml .Values.kubeletPlugin.containers.computeDomains.resources | nindent 10 }}
7475
env:
76+
- name: HELM_CHART_NAME
77+
value: {{ .Chart.Name }}
7578
- name: MASK_NVIDIA_DRIVER_PARAMS
7679
value: "{{ .Values.maskNvidiaDriverParams }}"
7780
- name: NVIDIA_CTK_PATH

templates/compute-domain-daemon-claim-template.tmpl.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ metadata:
77
finalizers:
88
- {{ .Finalizer }}
99
labels:
10+
app: {{ .AppLabelValue }}
1011
{{ .ComputeDomainLabelKey }}: {{ .ComputeDomainLabelValue }}
1112
{{ .TargetLabelKey }}: {{ .TargetLabelValue }}
1213
spec:

templates/compute-domain-daemon.tmpl.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ metadata:
77
finalizers:
88
- {{ .Finalizer }}
99
labels:
10+
app: {{ .AppLabelValue }}
1011
{{ .ComputeDomainLabelKey }}: {{ .ComputeDomainLabelValue }}
1112
spec:
1213
selector:

0 commit comments

Comments
 (0)