Skip to content

Commit 06e07ae

Browse files
shivamerlashivamerla
committed
Add default value for service port as 8000
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
1 parent 24913ab commit 06e07ae

22 files changed

Lines changed: 87 additions & 135 deletions

‎api/apps/v1alpha1/common_types.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,11 @@ type Service struct {
4343
Type corev1.ServiceType `json:"type,omitempty"`
4444
// override the default service name
4545
Name string `json:"name,omitempty"`
46-
// Port is the main api serving port
46+
// Port is the main api serving port (default: 8000)
4747
// +kubebuilder:validation:Minimum=1
4848
// +kubebuilder:validation:Maximum=65535
49-
Port *int32 `json:"port"`
49+
// +kubebuilder:default:=8000
50+
Port *int32 `json:"port,omitempty"`
5051
Annotations map[string]string `json:"annotations,omitempty"`
5152
}
5253

‎bundle/manifests/apps.nvidia.com_nemocustomizers.yaml‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -531,24 +531,21 @@ spec:
531531
additionalProperties:
532532
type: string
533533
type: object
534-
metricsPort:
535-
description: MetricsPort is the port to be used for the metrics
536-
collection (optional)
537-
format: int32
538-
type: integer
539534
name:
540535
description: override the default service name
541536
type: string
542537
port:
543-
description: Port is the main api serving port
538+
default: 8000
539+
description: 'Port is the main api serving port (default:
540+
8000)'
544541
format: int32
542+
maximum: 65535
543+
minimum: 1
545544
type: integer
546545
type:
547546
description: Service Type string describes ingress methods
548547
for a service
549548
type: string
550-
required:
551-
- port
552549
type: object
553550
required:
554551
- service

‎bundle/manifests/apps.nvidia.com_nemodatastores.yaml‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -530,24 +530,21 @@ spec:
530530
additionalProperties:
531531
type: string
532532
type: object
533-
metricsPort:
534-
description: MetricsPort is the port to be used for the metrics
535-
collection (optional)
536-
format: int32
537-
type: integer
538533
name:
539534
description: override the default service name
540535
type: string
541536
port:
542-
description: Port is the main api serving port
537+
default: 8000
538+
description: 'Port is the main api serving port (default:
539+
8000)'
543540
format: int32
541+
maximum: 65535
542+
minimum: 1
544543
type: integer
545544
type:
546545
description: Service Type string describes ingress methods
547546
for a service
548547
type: string
549-
required:
550-
- port
551548
type: object
552549
required:
553550
- service

‎bundle/manifests/apps.nvidia.com_nemoentitystores.yaml‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -528,24 +528,21 @@ spec:
528528
additionalProperties:
529529
type: string
530530
type: object
531-
metricsPort:
532-
description: MetricsPort is the port to be used for the metrics
533-
collection (optional)
534-
format: int32
535-
type: integer
536531
name:
537532
description: override the default service name
538533
type: string
539534
port:
540-
description: Port is the main api serving port
535+
default: 8000
536+
description: 'Port is the main api serving port (default:
537+
8000)'
541538
format: int32
539+
maximum: 65535
540+
minimum: 1
542541
type: integer
543542
type:
544543
description: Service Type string describes ingress methods
545544
for a service
546545
type: string
547-
required:
548-
- port
549546
type: object
550547
required:
551548
- service

‎bundle/manifests/apps.nvidia.com_nemoevaluators.yaml‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -568,24 +568,21 @@ spec:
568568
additionalProperties:
569569
type: string
570570
type: object
571-
metricsPort:
572-
description: MetricsPort is the port to be used for the metrics
573-
collection (optional)
574-
format: int32
575-
type: integer
576571
name:
577572
description: override the default service name
578573
type: string
579574
port:
580-
description: Port is the main api serving port
575+
default: 8000
576+
description: 'Port is the main api serving port (default:
577+
8000)'
581578
format: int32
579+
maximum: 65535
580+
minimum: 1
582581
type: integer
583582
type:
584583
description: Service Type string describes ingress methods
585584
for a service
586585
type: string
587-
required:
588-
- port
589586
type: object
590587
required:
591588
- service

‎bundle/manifests/apps.nvidia.com_nemoguardrails.yaml‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -504,24 +504,21 @@ spec:
504504
additionalProperties:
505505
type: string
506506
type: object
507-
metricsPort:
508-
description: MetricsPort is the port to be used for the metrics
509-
collection (optional)
510-
format: int32
511-
type: integer
512507
name:
513508
description: override the default service name
514509
type: string
515510
port:
516-
description: Port is the main api serving port
511+
default: 8000
512+
description: 'Port is the main api serving port (default:
513+
8000)'
517514
format: int32
515+
maximum: 65535
516+
minimum: 1
518517
type: integer
519518
type:
520519
description: Service Type string describes ingress methods
521520
for a service
522521
type: string
523-
required:
524-
- port
525522
type: object
526523
required:
527524
- service

‎bundle/manifests/apps.nvidia.com_nimpipelines.yaml‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -522,24 +522,21 @@ spec:
522522
additionalProperties:
523523
type: string
524524
type: object
525-
metricsPort:
526-
description: MetricsPort is the port to be used
527-
for the metrics collection (optional)
528-
format: int32
529-
type: integer
530525
name:
531526
description: override the default service name
532527
type: string
533528
port:
534-
description: Port is the main api serving port
529+
default: 8000
530+
description: 'Port is the main api serving port
531+
(default: 8000)'
535532
format: int32
533+
maximum: 65535
534+
minimum: 1
536535
type: integer
537536
type:
538537
description: Service Type string describes ingress
539538
methods for a service
540539
type: string
541-
required:
542-
- port
543540
type: object
544541
required:
545542
- service

‎bundle/manifests/apps.nvidia.com_nimservices.yaml‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -472,24 +472,21 @@ spec:
472472
additionalProperties:
473473
type: string
474474
type: object
475-
metricsPort:
476-
description: MetricsPort is the port to be used for the metrics
477-
collection (optional)
478-
format: int32
479-
type: integer
480475
name:
481476
description: override the default service name
482477
type: string
483478
port:
484-
description: Port is the main api serving port
479+
default: 8000
480+
description: 'Port is the main api serving port (default:
481+
8000)'
485482
format: int32
483+
maximum: 65535
484+
minimum: 1
486485
type: integer
487486
type:
488487
description: Service Type string describes ingress methods
489488
for a service
490489
type: string
491-
required:
492-
- port
493490
type: object
494491
required:
495492
- service

‎config/crd/bases/apps.nvidia.com_nemocustomizers.yaml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,8 @@ spec:
536536
type: string
537537
port:
538538
default: 8000
539-
description: Port is the main api serving port
539+
description: 'Port is the main api serving port (default:
540+
8000)'
540541
format: int32
541542
maximum: 65535
542543
minimum: 1
@@ -545,8 +546,6 @@ spec:
545546
description: Service Type string describes ingress methods
546547
for a service
547548
type: string
548-
required:
549-
- port
550549
type: object
551550
required:
552551
- service

‎config/crd/bases/apps.nvidia.com_nemodatastores.yaml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,8 @@ spec:
535535
type: string
536536
port:
537537
default: 8000
538-
description: Port is the main api serving port
538+
description: 'Port is the main api serving port (default:
539+
8000)'
539540
format: int32
540541
maximum: 65535
541542
minimum: 1
@@ -544,8 +545,6 @@ spec:
544545
description: Service Type string describes ingress methods
545546
for a service
546547
type: string
547-
required:
548-
- port
549548
type: object
550549
required:
551550
- service

0 commit comments

Comments
 (0)