Adding support to set inferencing platform on NIMService CRD

Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>

Author: visheshtanksale

cmd/main.go

@@ -43,7 +43,6 @@ import (
 	appsv1alpha1 "github.com/NVIDIA/k8s-nim-operator/api/apps/v1alpha1"
 	"github.com/NVIDIA/k8s-nim-operator/internal/conditions"
 	"github.com/NVIDIA/k8s-nim-operator/internal/controller"
-	"github.com/NVIDIA/k8s-nim-operator/internal/controller/platform"
 	"github.com/NVIDIA/k8s-nim-operator/internal/render"
 	// +kubebuilder:scaffold:imports
 )
@@ -96,16 +95,13 @@ func main() {
 		setupLog.Info("DEPRECATED: Global platform flag is deprecated. Use 'platform' field in NIMService CR instead.", "platform", platformType)
 		switch platformType {
 		case "standalone", "kserve":
-			// Valid platform types
+			// Valid platform types for the deprecated global platform flag. No need to throw an error.
 		default:
 			setupLog.Error(nil, "unsupported model-serving platform type", "platformType", platformType)
 			os.Exit(1)
 		}
 	}
 
-	// Create platform factory
-	platformFactory := platform.NewFactory()
-
 	// if the enable-http2 flag is false (the default), http/2 should be disabled
 	// due to its vulnerabilities. More specifically, disabling http/2 will
 	// prevent from being vulnerable to the HTTP/2 Stream Cancellation and
@@ -179,7 +175,6 @@ func main() {
 		discoveryClient,
 		render.NewRenderer("/manifests"),
 		ctrl.Log.WithName("controllers").WithName("NIMService"),
-		platformFactory,
 	).SetupWithManager(mgr); err != nil {
 		setupLog.Error(err, "unable to create controller", "controller", "NIMService")
 		os.Exit(1)

internal/controller/nimservice_controller.go

@@ -59,30 +59,28 @@ const NIMServiceFinalizer = "finalizer.nimservice.apps.nvidia.com"
 // NIMServiceReconciler reconciles a NIMService object.
 type NIMServiceReconciler struct {
 	client.Client
-	scheme                   *runtime.Scheme
-	log                      logr.Logger
-	updater                  conditions.Updater
-	discoveryClient          discovery.DiscoveryInterface
-	renderer                 render.Renderer
-	Config                   *rest.Config
-	InferencePlatformFactory *platform.Factory
-	orchestratorType         k8sutil.OrchestratorType
-	recorder                 record.EventRecorder
+	scheme           *runtime.Scheme
+	log              logr.Logger
+	updater          conditions.Updater
+	discoveryClient  discovery.DiscoveryInterface
+	renderer         render.Renderer
+	Config           *rest.Config
+	orchestratorType k8sutil.OrchestratorType
+	recorder         record.EventRecorder
 }
 
 // Ensure NIMServiceReconciler implements the Reconciler interface.
 var _ shared.Reconciler = &NIMServiceReconciler{}
 
 // NewNIMServiceReconciler creates a new reconciler for NIMService with the given platform factory.
-func NewNIMServiceReconciler(client client.Client, scheme *runtime.Scheme, updater conditions.Updater, discoveryClient discovery.DiscoveryInterface, renderer render.Renderer, log logr.Logger, platformFactory *platform.Factory) *NIMServiceReconciler {
+func NewNIMServiceReconciler(client client.Client, scheme *runtime.Scheme, updater conditions.Updater, discoveryClient discovery.DiscoveryInterface, renderer render.Renderer, log logr.Logger) *NIMServiceReconciler {
 	return &NIMServiceReconciler{
-		Client:                   client,
-		scheme:                   scheme,
-		updater:                  updater,
-		discoveryClient:          discoveryClient,
-		renderer:                 renderer,
-		log:                      log,
-		InferencePlatformFactory: platformFactory,
+		Client:          client,
+		scheme:          scheme,
+		updater:         updater,
+		discoveryClient: discoveryClient,
+		renderer:        renderer,
+		log:             log,
 	}
 }
 
@@ -134,7 +132,7 @@ func (r *NIMServiceReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 	logger.Info("Reconciling", "NIMService", nimService.Name)
 
 	// Get platform implementation based on NIMService's platform field
-	platformImpl, err := r.InferencePlatformFactory.GetInferencePlatform(nimService.Spec.InferencePlatform)
+	platformImpl, err := platform.GetInferencePlatform(nimService.Spec.InferencePlatform)
 	if err != nil {
 		logger.Error(err, "failed to get platform implementation", "platform", nimService.Spec.InferencePlatform)
 		return ctrl.Result{}, err

internal/controller/platform/platform.go

@@ -44,7 +44,7 @@ func NewFactory() *Factory {
 }
 
 // GetInferencePlatform returns an inference platform implementation based on the platform type.
-func (f *Factory) GetInferencePlatform(inferencePlatformType appsv1alpha1.PlatformType) (InferencePlatform, error) {
+func GetInferencePlatform(inferencePlatformType appsv1alpha1.PlatformType) (InferencePlatform, error) {
 	switch inferencePlatformType {
 	case appsv1alpha1.PlatformTypeStandalone, "": // Default to standalone for empty values
 		return &standalone.Standalone{}, nil