Skip to content

Commit 1453e3f

Browse files
Fixing test
Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
1 parent ab95deb commit 1453e3f

1 file changed

Lines changed: 5 additions & 12 deletions

File tree

internal/controller/platform/standalone/nimservice_test.go

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1410,15 +1410,10 @@ var _ = Describe("NIMServiceReconciler for a standalone platform", func() {
14101410

14111411
// Verify that NIM_MODEL_NAME environment variable is added
14121412
container := deployment.Spec.Template.Spec.Containers[0]
1413-
var nimModelNameEnv *corev1.EnvVar
1414-
for _, env := range container.Env {
1415-
if env.Name == "NIM_MODEL_NAME" {
1416-
nimModelNameEnv = &env
1417-
break
1418-
}
1419-
}
1420-
Expect(nimModelNameEnv).NotTo(BeNil(), "NIM_MODEL_NAME environment variable should be present")
1421-
Expect(nimModelNameEnv.Value).To(Equal("/model-store"), "NIM_MODEL_NAME should be set to /model-store")
1413+
Expect(container.Env).To(ContainElement(corev1.EnvVar{
1414+
Name: "NIM_MODEL_NAME",
1415+
Value: "/model-store",
1416+
}), "NIM_MODEL_NAME environment variable should be present and set to /model-store")
14221417

14231418
// Verify that other environment variables are still present
14241419
var customEnv *corev1.EnvVar
@@ -1548,9 +1543,7 @@ var _ = Describe("NIMServiceReconciler for a standalone platform", func() {
15481543

15491544
// Verify that NIM_MODEL_NAME environment variable is NOT added
15501545
container := deployment.Spec.Template.Spec.Containers[0]
1551-
for _, env := range container.Env {
1552-
Expect(env.Name).NotTo(Equal("NIM_MODEL_NAME"), "NIM_MODEL_NAME environment variable should not be present for non-Universal NIM")
1553-
}
1546+
Expect(container.Env).NotTo(ContainElement(corev1.EnvVar{Name: "NIM_MODEL_NAME"}), "NIM_MODEL_NAME environment variable should not be present for non-Universal NIM")
15541547

15551548
// Verify that other environment variables are still present
15561549
var customEnv *corev1.EnvVar

0 commit comments

Comments
 (0)