Addressing review comments

visheshtanksale · visheshtanksale · commit 2694a21e7cb9 · 2025-08-29T21:22:24.000Z
Signed-off-by: Vishesh Tanksale &lt;vtanksale@nvidia.com&gt;
diff --git a/internal/webhook/apps/v1alpha1/nimservice_webhook_validation_helper.go b/internal/webhook/apps/v1alpha1/nimservice_webhook_validation_helper.go
@@ -415,8 +415,8 @@ func validateGPURequirements(spec *appsv1alpha1.NIMServiceSpec, fldPath *field.P
 
 	gpuResourceName := corev1.ResourceName("nvidia.com/gpu")
 
-	// Check if GPU requests or limits are specified
-	if spec.Resources == nil {
+	// Check if GPU requests or limits are specified or DRA resources are specified
+	if spec.Resources == nil && len(spec.DRAResources) == 0 {
 		errList = append(errList, field.Required(fldPath.Child("resources"), "GPU resources must be specified for MultiNode deployments"))
 		return errList
 	}

Original file line number	Diff line number	Diff line change
`@@ -415,8 +415,8 @@ func validateGPURequirements(spec appsv1alpha1.NIMServiceSpec, fldPath field.P`
`415`	`415`
`416`	`416`	`gpuResourceName := corev1.ResourceName("nvidia.com/gpu")`
`417`	`417`
`418`		`- // Check if GPU requests or limits are specified`
`419`		`- if spec.Resources == nil {`
	`418`	`+ // Check if GPU requests or limits are specified or DRA resources are specified`
	`419`	`+ if spec.Resources == nil && len(spec.DRAResources) == 0 {`
`420`	`420`	`errList = append(errList, field.Required(fldPath.Child("resources"), "GPU resources must be specified for MultiNode deployments"))`
`421`	`421`	`return errList`
`422`	`422`	`}`