Skip to content

Commit 8de6a1e

Browse files
committed
Retained bug fixes after the httproutes reverting
Signed-off-by: Sheng Lin <shelin@nvidia.com>
1 parent 4650475 commit 8de6a1e

File tree

3 files changed

+14
-12
lines changed

3 files changed

+14
-12
lines changed

config/rbac/role.yaml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,10 @@ rules:
134134
- watch
135135
- apiGroups:
136136
- batch
137+
- batch.volcano.sh
137138
resources:
138139
- jobs
140+
- jobs/status
139141
verbs:
140142
- create
141143
- delete
@@ -144,15 +146,6 @@ rules:
144146
- patch
145147
- update
146148
- watch
147-
- apiGroups:
148-
- batch.volcano.sh
149-
resources:
150-
- jobs
151-
- jobs/status
152-
verbs:
153-
- get
154-
- list
155-
- watch
156149
- apiGroups:
157150
- config.openshift.io
158151
resources:

internal/controller/nemocustomizer_controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ func NewNemoCustomizerReconciler(client client.Client, scheme *runtime.Scheme, u
9393
// +kubebuilder:rbac:groups=run.ai,resources=trainingworkloads;runaijobs,verbs=get;list;watch;create;update;patch;delete
9494
// +kubebuilder:rbac:groups="",resources=events,verbs=get;list;watch;create
9595
// +kubebuilder:rbac:groups=nvidia.com,resources=nemotrainingjobs;nemotrainingjobs/status;nemoentityhandlers,verbs=create;get;list;watch;update;delete;patch
96-
// +kubebuilder:rbac:groups=batch.volcano.sh,resources=jobs;jobs/status,verbs=get;list;watch
96+
// +kubebuilder:rbac:groups=batch.volcano.sh,resources=jobs;jobs/status,verbs=get;list;watch;create;update;delete;patch
9797
// +kubebuilder:rbac:groups=nodeinfo.volcano.sh,resources=numatopologies,verbs=get;list;watch
9898
// +kubebuilder:rbac:groups=scheduling.incubator.k8s.io;scheduling.volcano.sh,resources=queues;queues/status;podgroups,verbs=get;list;watch
9999
// +kubebuilder:rbac:groups=config.openshift.io,resources=clusterversions;proxies,verbs=get;list;watch
@@ -105,7 +105,7 @@ func NewNemoCustomizerReconciler(client client.Client, scheme *runtime.Scheme, u
105105
// +kubebuilder:rbac:groups=apps,resources=deployments;statefulsets,verbs=get;list;watch;create;update;patch;delete
106106
// +kubebuilder:rbac:groups=monitoring.coreos.com,resources=servicemonitors;prometheusrules,verbs=get;list;watch;create;update;patch;delete
107107
// +kubebuilder:rbac:groups=scheduling.k8s.io,resources=priorityclasses,verbs=get;list;watch;create
108-
// +kubebuilder:rbac:groups=batch,resources=jobs,verbs=get;list;watch;create;update;patch;delete
108+
// +kubebuilder:rbac:groups=batch,resources=jobs;jobs/status,verbs=get;list;watch;create;update;patch;delete
109109
// +kubebuilder:rbac:groups=route.openshift.io,resources=routes,verbs=get;list;watch;create;update;patch;delete
110110
// +kubebuilder:rbac:groups=networking.k8s.io,resources=ingresses,verbs=get;list;watch;create;update;patch;delete
111111
// +kubebuilder:rbac:groups=autoscaling,resources=horizontalpodautoscalars,verbs=get;list;watch;create;update;patch;delete

internal/controller/nimservice_controller.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,8 @@ func (r *NIMServiceReconciler) SetupWithManager(mgr ctrl.Manager) error {
301301
&resourcev1beta2.ResourceClaim{},
302302
handler.EnqueueRequestsFromMapFunc(r.mapResourceClaimToNIMService),
303303
builder.WithPredicates(predicate.ResourceVersionChangedPredicate{}),
304-
)
304+
).
305+
Owns(&resourcev1beta2.ResourceClaim{})
305306
}
306307

307308
lwsCRDExists, err := k8sutil.CRDExists(r.discoveryClient, lwsv1.SchemeGroupVersion.WithResource("leaderworkersets"))
@@ -312,6 +313,14 @@ func (r *NIMServiceReconciler) SetupWithManager(mgr ctrl.Manager) error {
312313
nimServiceBuilder = nimServiceBuilder.Owns(&lwsv1.LeaderWorkerSet{})
313314
}
314315

316+
resourceClaimTemplateCRDExists, err := k8sutil.CRDExists(r.discoveryClient, resourcev1beta2.SchemeGroupVersion.WithResource("resourceclaimtemplates"))
317+
if err != nil {
318+
return err
319+
}
320+
if resourceClaimTemplateCRDExists {
321+
nimServiceBuilder = nimServiceBuilder.Owns(&resourcev1beta2.ResourceClaimTemplate{})
322+
}
323+
315324
isvcCRDExists, err := k8sutil.CRDExists(r.discoveryClient, kservev1beta1.SchemeGroupVersion.WithResource("inferenceservices"))
316325
if err != nil {
317326
return err

0 commit comments

Comments
 (0)