Removing validation check on PVC field (#579)

Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>

Author: visheshtanksale

api/apps/v1alpha1/common_types.go

@@ -244,8 +244,6 @@ type HFSecret struct {
 }
 
 // PersistentVolumeClaim defines the attributes of PVC.
-// +kubebuilder:validation:XValidation:rule="!has(self.create) || !self.create || (has(self.size) && self.size != \"\")", message="size is required for pvc creation"
-// +kubebuilder:validation:XValidation:rule="!has(self.create) || !self.create || (has(self.volumeAccessMode) && self.volumeAccessMode != \"\")", message="volumeAccessMode is required for pvc creation"
 type PersistentVolumeClaim struct {
 	// Create specifies whether to create a new PersistentVolumeClaim (PVC).
 	// If set to false, an existing PVC must be referenced via the `Name` field.

bundle/manifests/apps.nvidia.com_nemocustomizers.yaml

@@ -2080,13 +2080,6 @@ spec:
                           the PVC
                         type: string
                     type: object
-                    x-kubernetes-validations:
-                    - message: size is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.size)
-                        && self.size != "")'
-                    - message: volumeAccessMode is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
-                        && self.volumeAccessMode != "")'
                   networkConfig:
                     description: NetworkConfig is the network configuration for multi-node
                       training

bundle/manifests/apps.nvidia.com_nemodatastores.yaml

@@ -815,13 +815,6 @@ spec:
                       PVC
                     type: string
                 type: object
-                x-kubernetes-validations:
-                - message: size is required for pvc creation
-                  rule: '!has(self.create) || !self.create || (has(self.size) && self.size
-                    != "")'
-                - message: volumeAccessMode is required for pvc creation
-                  rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
-                    && self.volumeAccessMode != "")'
               replicas:
                 default: 1
                 minimum: 1

bundle/manifests/apps.nvidia.com_nemoguardrails.yaml

@@ -106,13 +106,6 @@ spec:
                           the PVC
                         type: string
                     type: object
-                    x-kubernetes-validations:
-                    - message: size is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.size)
-                        && self.size != "")'
-                    - message: volumeAccessMode is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
-                        && self.volumeAccessMode != "")'
                 type: object
                 x-kubernetes-validations:
                 - message: Cannot set both ConfigMap and PVC in ConfigStore

bundle/manifests/apps.nvidia.com_nimcaches.yaml

@@ -472,13 +472,6 @@ spec:
                           the PVC
                         type: string
                     type: object
-                    x-kubernetes-validations:
-                    - message: size is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.size)
-                        && self.size != "")'
-                    - message: volumeAccessMode is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
-                        && self.volumeAccessMode != "")'
                 type: object
               tolerations:
                 description: Tolerations for running the job to cache the NIM model

bundle/manifests/apps.nvidia.com_nimpipelines.yaml

@@ -2352,13 +2352,6 @@ spec:
                                     mode of the PVC
                                   type: string
                               type: object
-                              x-kubernetes-validations:
-                              - message: size is required for pvc creation
-                                rule: '!has(self.create) || !self.create || (has(self.size)
-                                  && self.size != "")'
-                              - message: volumeAccessMode is required for pvc creation
-                                rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
-                                  && self.volumeAccessMode != "")'
                             readOnly:
                               description: ReadOnly mode indicates if the volume should
                                 be mounted as read-only

bundle/manifests/apps.nvidia.com_nimservices.yaml

@@ -2263,13 +2263,6 @@ spec:
                           the PVC
                         type: string
                     type: object
-                    x-kubernetes-validations:
-                    - message: size is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.size)
-                        && self.size != "")'
-                    - message: volumeAccessMode is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
-                        && self.volumeAccessMode != "")'
                   readOnly:
                     description: ReadOnly mode indicates if the volume should be mounted
                       as read-only

config/crd/bases/apps.nvidia.com_nemocustomizers.yaml

@@ -2080,13 +2080,6 @@ spec:
                           the PVC
                         type: string
                     type: object
-                    x-kubernetes-validations:
-                    - message: size is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.size)
-                        && self.size != "")'
-                    - message: volumeAccessMode is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
-                        && self.volumeAccessMode != "")'
                   networkConfig:
                     description: NetworkConfig is the network configuration for multi-node
                       training

config/crd/bases/apps.nvidia.com_nemodatastores.yaml

@@ -815,13 +815,6 @@ spec:
                       PVC
                     type: string
                 type: object
-                x-kubernetes-validations:
-                - message: size is required for pvc creation
-                  rule: '!has(self.create) || !self.create || (has(self.size) && self.size
-                    != "")'
-                - message: volumeAccessMode is required for pvc creation
-                  rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
-                    && self.volumeAccessMode != "")'
               replicas:
                 default: 1
                 minimum: 1

config/crd/bases/apps.nvidia.com_nemoguardrails.yaml

@@ -106,13 +106,6 @@ spec:
                           the PVC
                         type: string
                     type: object
-                    x-kubernetes-validations:
-                    - message: size is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.size)
-                        && self.size != "")'
-                    - message: volumeAccessMode is required for pvc creation
-                      rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
-                        && self.volumeAccessMode != "")'
                 type: object
                 x-kubernetes-validations:
                 - message: Cannot set both ConfigMap and PVC in ConfigStore