Allow size of emptyDir volumes to be specified for NIMs Customizer

Author: shengnuo

api/apps/v1alpha1/nemo_customizer_types.go

@@ -29,6 +29,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	networkingv1 "k8s.io/api/networking/v1"
 	rbacv1 "k8s.io/api/rbac/v1"
+	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
 	"k8s.io/utils/ptr"
@@ -150,6 +151,8 @@ type TrainingConfig struct {
 	Tolerations []corev1.Toleration `json:"tolerations,omitempty"`
 	// PodAffinity for the training jobs
 	PodAffinity *corev1.PodAffinity `json:"podAffinity,omitempty"`
+	// EmptyDirSizeLimit is the size limit for the emptyDir volume for the training jobs
+	EmptyDirSizeLimit *resource.Quantity `json:"emptyDirSizeLimit,omitempty"`
 	// Resources for the training jobs
 	Resources *corev1.ResourceRequirements `json:"resources,omitempty"`
 }

api/apps/v1alpha1/nimservice_types.go

@@ -26,6 +26,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	networkingv1 "k8s.io/api/networking/v1"
 	rbacv1 "k8s.io/api/rbac/v1"
+	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
 	"k8s.io/utils/ptr"
@@ -135,6 +136,8 @@ type NIMServiceList struct {
 // NIMServiceStorage defines the attributes of various storage targets used to store the model.
 type NIMServiceStorage struct {
 	NIMCache NIMCacheVolSpec `json:"nimCache,omitempty"`
+	// EmptyDirSizeLimit is the size limit for the emptyDir volume
+	EmptyDirSizeLimit *resource.Quantity `json:"emptyDirSizeLimit,omitempty"`
 	// PersistentVolumeClaim is the pvc volume used for caching NIM
 	PVC PersistentVolumeClaim `json:"pvc,omitempty"`
 	// HostPath is the host path volume for caching NIM
@@ -449,7 +452,8 @@ func (n *NIMService) GetVolumes(modelPVC PersistentVolumeClaim) []corev1.Volume
 			Name: "dshm",
 			VolumeSource: corev1.VolumeSource{
 				EmptyDir: &corev1.EmptyDirVolumeSource{
-					Medium: corev1.StorageMediumMemory,
+					Medium:    corev1.StorageMediumMemory,
+					SizeLimit: n.Spec.Storage.EmptyDirSizeLimit,
 				},
 			},
 		},

internal/controller/nemocustomizer_controller.go

@@ -628,6 +628,12 @@ func (r *NemoCustomizerReconciler) addTrainingConfig(ctx context.Context, cfg ma
 	// Add PVC configuration
 	r.addWorkspacePVCConfig(ctx, trainingCfg, n)
 
+	emptyDir := map[string]interface{}{
+		"medium": "Memory",
+	}
+	if n.Spec.Training.EmptyDirSizeLimit != nil {
+		emptyDir["sizeLimit"] = n.Spec.Training.EmptyDirSizeLimit.String()
+	}
 	trainingCfg["volumes"] = []map[string]interface{}{
 		{
 			"name": "models",
@@ -637,10 +643,8 @@ func (r *NemoCustomizerReconciler) addTrainingConfig(ctx context.Context, cfg ma
 			},
 		},
 		{
-			"name": "dshm",
-			"emptyDir": map[string]interface{}{
-				"medium": "Memory",
-			},
+			"name":     "dshm",
+			"emptyDir": emptyDir,
 		},
 	}
 

manifests/deployment.yaml

@@ -121,6 +121,9 @@ spec:
         {{- if .EmptyDir }}
         emptyDir:
           medium: {{ .EmptyDir.Medium }}
+          {{- if .EmptyDir.SizeLimit }}
+          sizeLimit: {{ .EmptyDir.SizeLimit }}
+          {{- end }}
         {{- end }}
         {{- if .PersistentVolumeClaim }}
         persistentVolumeClaim: