Skip to content

Commit fd9a850

Browse files
committed
Fix PVC creation with an empty storage class name
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
1 parent 17c9e79 commit fd9a850

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

internal/shared/pvc.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,11 @@ import (
2727

2828
// ConstructPVC constructs a PVC from the custom spec from the user
2929
func ConstructPVC(pvc appsv1alpha1.PersistentVolumeClaim, pvcMeta metav1.ObjectMeta) (*corev1.PersistentVolumeClaim, error) {
30-
storageClassName := pvc.StorageClass
3130
size, err := resource.ParseQuantity(pvc.Size)
3231
if err != nil {
3332
return nil, fmt.Errorf("failed to parse size for pvc creation %s, err %v", pvcMeta.Name, err)
3433
}
35-
return &corev1.PersistentVolumeClaim{
34+
claim := &corev1.PersistentVolumeClaim{
3635
ObjectMeta: pvcMeta,
3736
Spec: corev1.PersistentVolumeClaimSpec{
3837
AccessModes: []corev1.PersistentVolumeAccessMode{pvc.VolumeAccessMode},
@@ -41,7 +40,12 @@ func ConstructPVC(pvc appsv1alpha1.PersistentVolumeClaim, pvcMeta metav1.ObjectM
4140
corev1.ResourceStorage: size,
4241
},
4342
},
44-
StorageClassName: &storageClassName,
4543
},
46-
}, nil
44+
}
45+
46+
if pvc.StorageClass != "" {
47+
claim.Spec.StorageClassName = &pvc.StorageClass
48+
}
49+
50+
return claim, nil
4751
}

0 commit comments

Comments
 (0)