diff --git a/internal/controller/nimcache_controller.go b/internal/controller/nimcache_controller.go index c1bb5b3c9..21cb4d730 100644 --- a/internal/controller/nimcache_controller.go +++ b/internal/controller/nimcache_controller.go @@ -1132,7 +1132,7 @@ func (r *NIMCacheReconciler) constructJob(ctx context.Context, nimCache *appsv1a { Name: NIMCacheContainerName, Image: nimCache.Spec.Source.NGC.ModelPuller, - Args: []string{"download-to-cache"}, + Command: []string{"download-to-cache"}, EnvFrom: nimCache.Spec.Source.EnvFromSecrets(), Env: []corev1.EnvVar{ { diff --git a/internal/controller/nimcache_controller_test.go b/internal/controller/nimcache_controller_test.go index 8ab472f45..9b3dd71fa 100644 --- a/internal/controller/nimcache_controller_test.go +++ b/internal/controller/nimcache_controller_test.go @@ -426,7 +426,8 @@ var _ = Describe("NIMCache Controller", func() { Expect(job.Name).To(Equal(getJobName(nimCache))) Expect(job.Spec.Template.Spec.Containers[0].Image).To(Equal("nvcr.io/nim:test")) Expect(job.Spec.Template.Spec.ImagePullSecrets[0].Name).To(Equal("my-secret")) - Expect(job.Spec.Template.Spec.Containers[0].Args).To(ContainElements("download-to-cache", "--profiles", "36fc1fa4fc35c1d54da115a39323080b08d7937dceb8ba47be44f4da0ec720ff")) + Expect(job.Spec.Template.Spec.Containers[0].Command).To(ContainElements("download-to-cache")) + Expect(job.Spec.Template.Spec.Containers[0].Args).To(ContainElements("--profiles", "36fc1fa4fc35c1d54da115a39323080b08d7937dceb8ba47be44f4da0ec720ff")) Expect(*job.Spec.Template.Spec.SecurityContext.RunAsUser).To(Equal(int64(1000))) Expect(*job.Spec.Template.Spec.SecurityContext.FSGroup).To(Equal(int64(2000))) Expect(*job.Spec.Template.Spec.SecurityContext.RunAsNonRoot).To(Equal(true)) @@ -456,7 +457,8 @@ var _ = Describe("NIMCache Controller", func() { Expect(job.Name).To(Equal(getJobName(nimCache))) Expect(job.Spec.Template.Spec.Containers[0].Image).To(Equal("nvcr.io/nim:test")) Expect(job.Spec.Template.Spec.ImagePullSecrets[0].Name).To(Equal("my-secret")) - Expect(job.Spec.Template.Spec.Containers[0].Args).To(ContainElements("download-to-cache", "--profiles", "36fc1fa4fc35c1d54da115a39323080b08d7937dceb8ba47be44f4da0ec720ff", "04fdb4d11f01be10c31b00e7c0540e2835e89a0079b483ad2dd3c25c8cc12345")) + Expect(job.Spec.Template.Spec.Containers[0].Command).To(ContainElements("download-to-cache")) + Expect(job.Spec.Template.Spec.Containers[0].Args).To(ContainElements("--profiles", "36fc1fa4fc35c1d54da115a39323080b08d7937dceb8ba47be44f4da0ec720ff", "04fdb4d11f01be10c31b00e7c0540e2835e89a0079b483ad2dd3c25c8cc12345")) Expect(*job.Spec.Template.Spec.SecurityContext.RunAsUser).To(Equal(int64(1000))) Expect(*job.Spec.Template.Spec.SecurityContext.FSGroup).To(Equal(int64(2000))) Expect(*job.Spec.Template.Spec.SecurityContext.RunAsNonRoot).To(Equal(true)) @@ -482,7 +484,8 @@ var _ = Describe("NIMCache Controller", func() { Expect(job.Name).To(Equal(getJobName(nimCache))) Expect(job.Spec.Template.Spec.Containers[0].Image).To(Equal("nvcr.io/nim:test")) Expect(job.Spec.Template.Spec.ImagePullSecrets[0].Name).To(Equal("my-secret")) - Expect(job.Spec.Template.Spec.Containers[0].Args).To(ContainElements("download-to-cache", "--all")) + Expect(job.Spec.Template.Spec.Containers[0].Command).To(ContainElements("download-to-cache")) + Expect(job.Spec.Template.Spec.Containers[0].Args).To(ContainElements("--all")) }) It("should create a job with the correct specifications", func() {