fix(mocknvml): address golangci-lint issues

Fix linter errors reported by CI:
- Remove embedded field "Device" from selectors (QF1008 staticcheck)
- Check error return values from fmt.Sscanf (errcheck)
- Add nolint directive for intentional uintptr to unsafe.Pointer conversion

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Author: ArangoGutierrez

pkg/gpu/mocknvml/engine/device.go

@@ -50,22 +50,22 @@ func NewConfigurableDevice(index int, baseDevice *dgxa100.Device, config *Device
 	// Override base device properties from config
 	if config != nil {
 		if config.Name != "" {
-			dev.Device.Name = config.Name
+			dev.Name = config.Name
 		}
 		if config.Architecture != "" {
-			dev.Device.Architecture = parseArchitecture(config.Architecture)
+			dev.Architecture = parseArchitecture(config.Architecture)
 		}
 		if config.Brand != "" {
-			dev.Device.Brand = parseBrand(config.Brand)
+			dev.Brand = parseBrand(config.Brand)
 		}
 		if config.ComputeCapability != nil {
-			dev.Device.CudaComputeCapability = dgxa100.CudaComputeCapability{
+			dev.CudaComputeCapability = dgxa100.CudaComputeCapability{
 				Major: config.ComputeCapability.Major,
 				Minor: config.ComputeCapability.Minor,
 			}
 		}
 		if config.Memory != nil {
-			dev.Device.MemoryInfo = nvml.Memory{
+			dev.MemoryInfo = nvml.Memory{
 				Total: config.Memory.TotalBytes,
 				Free:  config.Memory.FreeBytes,
 				Used:  config.Memory.UsedBytes,
@@ -75,22 +75,22 @@ func NewConfigurableDevice(index int, baseDevice *dgxa100.Device, config *Device
 
 	// Override UUID if provided
 	if uuid != "" {
-		dev.Device.UUID = uuid
+		dev.UUID = uuid
 	}
 
 	// Override PCI bus ID if provided
 	if pciBusID != "" {
-		dev.Device.PciBusID = pciBusID
+		dev.PciBusID = pciBusID
 	}
 
 	// Set minor number
-	dev.Device.Minor = minorNumber
+	dev.Minor = minorNumber
 
 	// Initialize cached values
 	dev.initBAR1Memory()
 	dev.initPciInfo()
 
-	debugLog("[DEVICE %d] Created: name=%s uuid=%s pci=%s\n", index, dev.Device.Name, dev.Device.UUID, dev.Device.PciBusID)
+	debugLog("[DEVICE %d] Created: name=%s uuid=%s pci=%s\n", index, dev.Name, dev.UUID, dev.PciBusID)
 
 	return dev
 }
@@ -118,7 +118,7 @@ func (d *ConfigurableDevice) initPciInfo() {
 	n, _ := fmt.Sscanf(d.PciBusID, "%x:%x:%x.%x", &domain, &bus, &device, &function)
 	if n != 4 {
 		// Try alternate format with full domain
-		fmt.Sscanf(d.PciBusID, "%08x:%02x:%02x.%x", &domain, &bus, &device, &function)
+		_, _ = fmt.Sscanf(d.PciBusID, "%08x:%02x:%02x.%x", &domain, &bus, &device, &function)
 	}
 
 	d.pciInfo = nvml.PciInfo{
@@ -167,18 +167,18 @@ func (d *ConfigurableDevice) GetBAR1MemoryInfo() (nvml.BAR1Memory, nvml.Return)
 
 // GetMemoryInfo returns GPU memory information
 func (d *ConfigurableDevice) GetMemoryInfo() (nvml.Memory, nvml.Return) {
-	debugLog("[NVML] nvmlDeviceGetMemoryInfo -> total=%d\n", d.Device.MemoryInfo.Total)
-	return d.Device.MemoryInfo, nvml.SUCCESS
+	debugLog("[NVML] nvmlDeviceGetMemoryInfo -> total=%d\n", d.MemoryInfo.Total)
+	return d.MemoryInfo, nvml.SUCCESS
 }
 
 // GetMemoryInfo_v2 returns GPU memory information (v2 API)
 func (d *ConfigurableDevice) GetMemoryInfo_v2() (nvml.Memory_v2, nvml.Return) {
 	mem := nvml.Memory_v2{
 		Version:  2,
-		Total:    d.Device.MemoryInfo.Total,
+		Total:    d.MemoryInfo.Total,
 		Reserved: 0,
-		Free:     d.Device.MemoryInfo.Free,
-		Used:     d.Device.MemoryInfo.Used,
+		Free:     d.MemoryInfo.Free,
+		Used:     d.MemoryInfo.Used,
 	}
 	// If we have config with reserved bytes, use it
 	if d.config != nil && d.config.Memory != nil {
@@ -519,7 +519,7 @@ func (d *ConfigurableDevice) GetFanSpeed() (uint32, nvml.Return) {
 	speed := uint32(0)
 	if d.config != nil && d.config.Fan != nil {
 		if d.config.Fan.SpeedPercent != "" && d.config.Fan.SpeedPercent != "N/A" {
-			fmt.Sscanf(d.config.Fan.SpeedPercent, "%d", &speed)
+			_, _ = fmt.Sscanf(d.config.Fan.SpeedPercent, "%d", &speed)
 		}
 	}
 	debugLog("[NVML] nvmlDeviceGetFanSpeed -> %d%%\n", speed)
@@ -797,22 +797,22 @@ func (d *ConfigurableDevice) GetMigMode() (int, int, nvml.Return) {
 
 // GetArchitecture returns GPU architecture
 func (d *ConfigurableDevice) GetArchitecture() (nvml.DeviceArchitecture, nvml.Return) {
-	debugLog("[NVML] nvmlDeviceGetArchitecture -> %d\n", d.Device.Architecture)
-	return d.Device.Architecture, nvml.SUCCESS
+	debugLog("[NVML] nvmlDeviceGetArchitecture -> %d\n", d.Architecture)
+	return d.Architecture, nvml.SUCCESS
 }
 
 // GetCudaComputeCapability returns CUDA compute capability
 func (d *ConfigurableDevice) GetCudaComputeCapability() (int, int, nvml.Return) {
-	major := d.Device.CudaComputeCapability.Major
-	minor := d.Device.CudaComputeCapability.Minor
+	major := d.CudaComputeCapability.Major
+	minor := d.CudaComputeCapability.Minor
 	debugLog("[NVML] nvmlDeviceGetCudaComputeCapability -> %d.%d\n", major, minor)
 	return major, minor, nvml.SUCCESS
 }
 
 // GetBrand returns device brand
 func (d *ConfigurableDevice) GetBrand() (nvml.BrandType, nvml.Return) {
-	debugLog("[NVML] nvmlDeviceGetBrand -> %d\n", d.Device.Brand)
-	return d.Device.Brand, nvml.SUCCESS
+	debugLog("[NVML] nvmlDeviceGetBrand -> %d\n", d.Brand)
+	return d.Brand, nvml.SUCCESS
 }
 
 // GetEncoderUtilization returns encoder utilization

pkg/gpu/mocknvml/engine/handles.go

@@ -110,6 +110,8 @@ func (ht *HandleTable) Clear() {
 
 	// Free all allocated C handle blocks
 	for handle := range ht.devices {
+		//nolint:govet // Converting uintptr back to unsafe.Pointer is intentional here -
+		// the handle was originally allocated as C memory and stored as uintptr for map key use
 		C.freeHandle(unsafe.Pointer(handle))
 	}