fix: dynamically assign raid type when creating a storage volume for Dells (#40)

This PR dynamically finds the RAID type based on the amount of drives
present in the BOSS controller instead of taking it as input in
`create_storage_volume()`.

- 1 drive = `RAID0`
- 2 drives = `RAID1`
- else, throw an error

Signed-off-by: Krish Dandiwala <kdandiwala@nvidia.com>

Author: krish-nvidia

src/ami.rs

@@ -825,10 +825,9 @@ impl Redfish for Bmc {
         &self,
         controller_id: &str,
         volume_name: &str,
-        raid_type: &str,
     ) -> Result<Option<String>, RedfishError> {
         self.s
-            .create_storage_volume(controller_id, volume_name, raid_type)
+            .create_storage_volume(controller_id, volume_name)
             .await
     }
 

src/dell.rs

@@ -1011,9 +1011,21 @@ impl Redfish for Bmc {
         &self,
         controller_id: &str,
         volume_name: &str,
-        raid_type: &str,
     ) -> Result<Option<String>, RedfishError> {
         let drives = self.get_storage_drives(controller_id).await?;
+
+        let raid_type = match drives.as_array().map(|a| a.len()).unwrap_or(0) {
+            1 => "RAID0",
+            2 => "RAID1",
+            n => {
+                return Err(RedfishError::GenericError {
+                    error: format!(
+                        "Expected 1 or 2 drives for BOSS controller {controller_id}, found {n}"
+                    ),
+                });
+            }
+        };
+
         Ok(Some(
             self.create_storage_volume(controller_id, volume_name, raid_type, drives)
                 .await?,

src/hpe.rs

@@ -881,10 +881,9 @@ impl Redfish for Bmc {
         &self,
         controller_id: &str,
         volume_name: &str,
-        raid_type: &str,
     ) -> Result<Option<String>, RedfishError> {
         self.s
-            .create_storage_volume(controller_id, volume_name, raid_type)
+            .create_storage_volume(controller_id, volume_name)
             .await
     }
 

src/lenovo.rs

@@ -935,10 +935,9 @@ impl Redfish for Bmc {
         &self,
         controller_id: &str,
         volume_name: &str,
-        raid_type: &str,
     ) -> Result<Option<String>, RedfishError> {
         self.s
-            .create_storage_volume(controller_id, volume_name, raid_type)
+            .create_storage_volume(controller_id, volume_name)
             .await
     }
 

src/lib.rs

@@ -510,7 +510,6 @@ pub trait Redfish: Send + Sync + 'static {
         &self,
         controller_id: &str,
         volume_name: &str,
-        raid_type: &str,
     ) -> Result<Option<String>, RedfishError>;
 
     fn ac_powercycle_supported_by_power(&self) -> bool;

src/liteon_powershelf.rs

@@ -632,10 +632,9 @@ impl Redfish for Bmc {
         &self,
         controller_id: &str,
         volume_name: &str,
-        raid_type: &str,
     ) -> Result<Option<String>, RedfishError> {
         self.s
-            .create_storage_volume(controller_id, volume_name, raid_type)
+            .create_storage_volume(controller_id, volume_name)
             .await
     }
 

src/nvidia_dpu.rs

@@ -798,10 +798,9 @@ impl Redfish for Bmc {
         &self,
         controller_id: &str,
         volume_name: &str,
-        raid_type: &str,
     ) -> Result<Option<String>, RedfishError> {
         self.s
-            .create_storage_volume(controller_id, volume_name, raid_type)
+            .create_storage_volume(controller_id, volume_name)
             .await
     }
 

src/nvidia_gbswitch.rs

@@ -724,10 +724,9 @@ impl Redfish for Bmc {
         &self,
         controller_id: &str,
         volume_name: &str,
-        raid_type: &str,
     ) -> Result<Option<String>, RedfishError> {
         self.s
-            .create_storage_volume(controller_id, volume_name, raid_type)
+            .create_storage_volume(controller_id, volume_name)
             .await
     }
 

src/nvidia_gbx00.rs

@@ -1017,10 +1017,9 @@ impl Redfish for Bmc {
         &self,
         controller_id: &str,
         volume_name: &str,
-        raid_type: &str,
     ) -> Result<Option<String>, RedfishError> {
         self.s
-            .create_storage_volume(controller_id, volume_name, raid_type)
+            .create_storage_volume(controller_id, volume_name)
             .await
     }
 

src/nvidia_gh200.rs

@@ -684,10 +684,9 @@ impl Redfish for Bmc {
         &self,
         controller_id: &str,
         volume_name: &str,
-        raid_type: &str,
     ) -> Result<Option<String>, RedfishError> {
         self.s
-            .create_storage_volume(controller_id, volume_name, raid_type)
+            .create_storage_volume(controller_id, volume_name)
             .await
     }