Skip to content

Commit dbcf2c1

Browse files
authored
Update comm.py (#34)
Swapping h and w comms, so that w comm is fastest.
1 parent 3093425 commit dbcf2c1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

makani/utils/comm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ def init(model_parallel_sizes=[1, 1, 1, 1], model_parallel_names=["h", "w", "fin
136136
pconfig.add_node(ProcessGroupNode("spatial"), parent="model")
137137
pconfig.add_node(ProcessGroupNode("matmul"), parent="model")
138138
# subgroups for spatial
139-
pconfig.add_node(ProcessGroupNode("h"), parent="spatial")
140139
pconfig.add_node(ProcessGroupNode("w"), parent="spatial")
140+
pconfig.add_node(ProcessGroupNode("h"), parent="spatial")
141141
# subgroups for matmul:
142142
pconfig.add_node(ProcessGroupNode("fin"), parent="matmul")
143143
pconfig.add_node(ProcessGroupNode("fout"), parent="matmul")

0 commit comments

Comments
 (0)