Skip to content

Commit 1f39785

Browse files
Merge remote-tracking branch 'upstream/main' into add-pynvbench
2 parents be0d834 + 3de9dc9 commit 1f39785

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

nvbench/detail/measure_cold.cu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ void measure_cold_base::generate_summaries()
242242
auto &summ = m_state.add_summary("nv/cold/time/cpu/stdev/absolute");
243243
summ.set_string("name", "Noise");
244244
summ.set_string("hint", "percentage");
245-
summ.set_string("description", "Relative standard deviation of isolated CPU times");
245+
summ.set_string("description", "Standard deviation of isolated CPU times");
246246
summ.set_float64("value", cpu_stdev);
247247
summ.set_string("hide", "Hidden by default.");
248248
}

nvbench/detail/measure_cold.cuh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -153,18 +153,16 @@ struct measure_cold_base::kernel_launch_timer
153153
m_measure.gpu_frequency_start();
154154
}
155155
m_measure.m_cuda_timer.start(m_measure.m_launch.get_stream());
156-
if (m_disable_blocking_kernel)
157-
{
158-
m_measure.m_cpu_timer.start();
159-
}
156+
// start CPU timer irrespective of use of blocking kernel
157+
// Ref: https://github.com/NVIDIA/nvbench/issues/249
158+
m_measure.m_cpu_timer.start();
160159
}
161160

162161
__forceinline__ void stop()
163162
{
164163
m_measure.m_cuda_timer.stop(m_measure.m_launch.get_stream());
165164
if (!m_disable_blocking_kernel)
166165
{
167-
m_measure.m_cpu_timer.start();
168166
m_measure.unblock_stream();
169167
}
170168
if (m_measure.m_check_throttling)

0 commit comments

Comments
 (0)