Skip to content

Commit 9baf88b

Browse files
Change method nameing from camelCase to snake_case
This ensures names of Python API methods are consistent with those of C++ counterparts.
1 parent a507ffe commit 9baf88b

File tree

1 file changed

+40
-39
lines changed

1 file changed

+40
-39
lines changed

python/src/py_nvbench.cpp

Lines changed: 40 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -255,24 +255,24 @@ PYBIND11_MODULE(_nvbench, m)
255255
auto py_launch_cls = py::class_<nvbench::launch>(m, "Launch");
256256

257257
py_launch_cls.def(
258-
"getStream",
258+
"get_stream",
259259
[](nvbench::launch &launch) { return std::ref(launch.get_stream()); },
260260
py::return_value_policy::reference);
261261

262262
// == STEP 4
263263
// Define Benchmark class
264264

265265
auto py_benchmark_cls = py::class_<nvbench::benchmark_base>(m, "Benchmark");
266-
py_benchmark_cls.def("getName", &nvbench::benchmark_base::get_name);
266+
py_benchmark_cls.def("get_name", &nvbench::benchmark_base::get_name);
267267
py_benchmark_cls.def(
268-
"addInt64Axis",
268+
"add_int64_axis",
269269
[](nvbench::benchmark_base &self, std::string name, const std::vector<nvbench::int64_t> &data) {
270270
self.add_int64_axis(std::move(name), data);
271271
return std::ref(self);
272272
},
273273
py::return_value_policy::reference);
274274
py_benchmark_cls.def(
275-
"addFloat64Axis",
275+
"add_float64_axis",
276276
[](nvbench::benchmark_base &self,
277277
std::string name,
278278
const std::vector<nvbench::float64_t> &data) {
@@ -281,21 +281,21 @@ PYBIND11_MODULE(_nvbench, m)
281281
},
282282
py::return_value_policy::reference);
283283
py_benchmark_cls.def(
284-
"addStringAxis",
284+
"add_string_axis",
285285
[](nvbench::benchmark_base &self, std::string name, const std::vector<std::string> &data) {
286286
self.add_string_axis(std::move(name), data);
287287
return std::ref(self);
288288
},
289289
py::return_value_policy::reference);
290290
py_benchmark_cls.def(
291-
"setName",
291+
"set_name",
292292
[](nvbench::benchmark_base &self, std::string name) {
293293
self.set_name(std::move(name));
294294
return std::ref(self);
295295
},
296296
py::return_value_policy::reference);
297297
py_benchmark_cls.def(
298-
"setIsCPUOnly",
298+
"set_is_cpu_only",
299299
[](nvbench::benchmark_base &self, bool is_cpu_only) {
300300
self.set_is_cpu_only(is_cpu_only);
301301
return std::ref(self);
@@ -373,13 +373,13 @@ PYBIND11_MODULE(_nvbench, m)
373373
using state_ref_t = std::reference_wrapper<nvbench::state>;
374374
auto pystate_cls = py::class_<nvbench::state>(m, "State");
375375

376-
pystate_cls.def("hasDevice", [](const nvbench::state &state) -> bool {
376+
pystate_cls.def("has_device", [](const nvbench::state &state) -> bool {
377377
return static_cast<bool>(state.get_device());
378378
});
379-
pystate_cls.def("hasPrinters", [](const nvbench::state &state) -> bool {
379+
pystate_cls.def("has_printers", [](const nvbench::state &state) -> bool {
380380
return state.get_benchmark().get_printer().has_value();
381381
});
382-
pystate_cls.def("getDevice", [](const nvbench::state &state) {
382+
pystate_cls.def("get_device", [](const nvbench::state &state) {
383383
auto dev = state.get_device();
384384
if (dev.has_value())
385385
{
@@ -389,32 +389,32 @@ PYBIND11_MODULE(_nvbench, m)
389389
});
390390

391391
pystate_cls.def(
392-
"getStream",
392+
"get_stream",
393393
[](nvbench::state &state) { return std::ref(state.get_cuda_stream()); },
394394
py::return_value_policy::reference);
395395

396-
pystate_cls.def("getInt64", &nvbench::state::get_int64);
397-
pystate_cls.def("getInt64", &nvbench::state::get_int64_or_default);
396+
pystate_cls.def("get_int64", &nvbench::state::get_int64);
397+
pystate_cls.def("get_int64", &nvbench::state::get_int64_or_default);
398398

399-
pystate_cls.def("getFloat64", &nvbench::state::get_float64);
400-
pystate_cls.def("getFloat64", &nvbench::state::get_float64_or_default);
399+
pystate_cls.def("get_float64", &nvbench::state::get_float64);
400+
pystate_cls.def("get_float64", &nvbench::state::get_float64_or_default);
401401

402-
pystate_cls.def("getString", &nvbench::state::get_string);
403-
pystate_cls.def("getString", &nvbench::state::get_string_or_default);
402+
pystate_cls.def("get_string", &nvbench::state::get_string);
403+
pystate_cls.def("get_string", &nvbench::state::get_string_or_default);
404404

405-
pystate_cls.def("addElementCount",
405+
pystate_cls.def("add_element_count",
406406
&nvbench::state::add_element_count,
407407
py::arg("count"),
408408
py::arg("column_name") = py::str(""));
409-
pystate_cls.def("setElementCount", &nvbench::state::set_element_count);
410-
pystate_cls.def("getElementCount", &nvbench::state::get_element_count);
409+
pystate_cls.def("set_element_count", &nvbench::state::set_element_count);
410+
pystate_cls.def("get_element_count", &nvbench::state::get_element_count);
411411

412412
pystate_cls.def("skip", &nvbench::state::skip);
413-
pystate_cls.def("isSkipped", &nvbench::state::is_skipped);
414-
pystate_cls.def("getSkipReason", &nvbench::state::get_skip_reason);
413+
pystate_cls.def("is_skipped", &nvbench::state::is_skipped);
414+
pystate_cls.def("get_skip_reason", &nvbench::state::get_skip_reason);
415415

416416
pystate_cls.def(
417-
"addGlobalMemoryReads",
417+
"add_global_memory_reads",
418418
[](nvbench::state &state, std::size_t nbytes, const std::string &column_name) -> void {
419419
state.add_global_memory_reads(nbytes, column_name);
420420
},
@@ -423,7 +423,7 @@ PYBIND11_MODULE(_nvbench, m)
423423
py::pos_only{},
424424
py::arg("column_name") = py::str(""));
425425
pystate_cls.def(
426-
"addGlobalMemoryWrites",
426+
"add_global_memory_writes",
427427
[](nvbench::state &state, std::size_t nbytes, const std::string &column_name) -> void {
428428
state.add_global_memory_writes(nbytes, column_name);
429429
},
@@ -432,28 +432,28 @@ PYBIND11_MODULE(_nvbench, m)
432432
py::pos_only{},
433433
py::arg("column_name") = py::str(""));
434434
pystate_cls.def(
435-
"getBenchmark",
435+
"get_benchmark",
436436
[](const nvbench::state &state) { return std::ref(state.get_benchmark()); },
437437
py::return_value_policy::reference);
438-
pystate_cls.def("getThrottleThreshold", &nvbench::state::get_throttle_threshold);
438+
pystate_cls.def("get_throttle_threshold", &nvbench::state::get_throttle_threshold);
439439

440-
pystate_cls.def("getMinSamples", &nvbench::state::get_min_samples);
441-
pystate_cls.def("setMinSamples", &nvbench::state::set_min_samples);
440+
pystate_cls.def("get_min_samples", &nvbench::state::get_min_samples);
441+
pystate_cls.def("set_min_samples", &nvbench::state::set_min_samples);
442442

443-
pystate_cls.def("getDisableBlockingKernel", &nvbench::state::get_disable_blocking_kernel);
444-
pystate_cls.def("setDisableBlockingKernel", &nvbench::state::set_disable_blocking_kernel);
443+
pystate_cls.def("get_disable_blocking_kernel", &nvbench::state::get_disable_blocking_kernel);
444+
pystate_cls.def("set_disable_blocking_kernel", &nvbench::state::set_disable_blocking_kernel);
445445

446-
pystate_cls.def("getRunOnce", &nvbench::state::get_run_once);
447-
pystate_cls.def("setRunOnce", &nvbench::state::set_run_once);
446+
pystate_cls.def("get_run_once", &nvbench::state::get_run_once);
447+
pystate_cls.def("set_run_once", &nvbench::state::set_run_once);
448448

449-
pystate_cls.def("getTimeout", &nvbench::state::get_timeout);
450-
pystate_cls.def("setTimeout", &nvbench::state::set_timeout);
449+
pystate_cls.def("get_timeout", &nvbench::state::get_timeout);
450+
pystate_cls.def("set_timeout", &nvbench::state::set_timeout);
451451

452-
pystate_cls.def("getBlockingKernelTimeout", &nvbench::state::get_blocking_kernel_timeout);
453-
pystate_cls.def("setBlockingKernelTimeout", &nvbench::state::set_blocking_kernel_timeout);
452+
pystate_cls.def("get_blocking_kernel_timeout", &nvbench::state::get_blocking_kernel_timeout);
453+
pystate_cls.def("set_blocking_kernel_timeout", &nvbench::state::set_blocking_kernel_timeout);
454454

455-
pystate_cls.def("collectCUPTIMetrics", &nvbench::state::collect_cupti_metrics);
456-
pystate_cls.def("isCUPTIRequired", &nvbench::state::is_cupti_required);
455+
pystate_cls.def("collect_cupti_metrics", &nvbench::state::collect_cupti_metrics);
456+
pystate_cls.def("is_cupti_required", &nvbench::state::is_cupti_required);
457457

458458
pystate_cls.def(
459459
"exec",
@@ -533,6 +533,7 @@ PYBIND11_MODULE(_nvbench, m)
533533
m.def(
534534
"register",
535535
[&](py::object fn) { return std::ref(global_registry->add_bench(fn)); },
536+
"Register benchmark function of type Callable[[nvbench.State], None]",
536537
py::return_value_policy::reference);
537538

538539
m.def(
@@ -545,6 +546,6 @@ PYBIND11_MODULE(_nvbench, m)
545546
std::vector<std::string> args = py::cast<std::vector<std::string>>(argv);
546547
global_registry->run(args);
547548
},
548-
"Run all benchmarks",
549+
"Run all registered benchmarks",
549550
py::arg("argv") = py::list());
550551
}

0 commit comments

Comments
 (0)