Skip to content

Commit cc500ed

Browse files
Anilreddy2309claude
andcommitted
Remove dead document_grounded_sdg registration of GenselectAnswersStage
GenselectAnswersStage was registered twice: once for recipe=finance/workflow=template_based_sdg (still used, see template-based-sdg*.yaml), and once for recipe=finance/workflow=document_grounded_sdg. The second registration is unreachable -- every document-grounded-sdg workflow YAML uses gym_genselect_answers instead (a separate stage registered in nvflow/generic_stage/sdg/document_grounded/__init__.py), and document-grounded-sdg.yaml's own comment says gym_genselect_answers "replaces genselect_answers for DG-SDG". No config anywhere references finance.document_grounded_sdg.genselect_answers, and the stage's own docs (docs/recipes/finance/stages/template-based-sdg.md) only document the template_based_sdg registration. Verified via `nflow list-stages --recipe finance --workflow document_grounded_sdg`: the 7 registered stages are unchanged before and after (dg_sdg_preprocess, generate_verified_questions, generate_answers, gym_genselect_answers, evaluate_answers, aggregate_answers, dgsdg_post_process), matching the documented pipeline in docs/development/sdg/document_grounded/ADDING_A_DOMAIN.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Anil Balireddy <anilbalireddi@gmail.com>
1 parent 9f34b6b commit cc500ed

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

nvflow/recipes/finance/stages/sdg/genselect_answers.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@
2222

2323

2424
@StageRegistry.register(recipe="finance", workflow="template_based_sdg", stage="genselect_answers")
25-
@StageRegistry.register(
26-
recipe="finance",
27-
workflow="document_grounded_sdg",
28-
stage="genselect_answers",
29-
)
3025
class GenselectAnswersStage(BaseStage):
3126
"""Generate and select best answers using parallel thinking."""
3227

0 commit comments

Comments
 (0)