Skip to content

Commit 9c6dd94

Browse files
committed
Merge branch 'disc-typos' into 'main'
fix minor typos and rm unused logger param See merge request nvidia/container-toolkit/container-toolkit!540
2 parents b3519fa + 9c1f0bb commit 9c6dd94

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

internal/discover/filter.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ type filtered struct {
3030
filter Filter
3131
}
3232

33-
// newFilteredDisoverer creates a discoverer that applies the specified filter to the returned entities of the discoverer
34-
func newFilteredDisoverer(logger logger.Interface, applyTo Discover, filter Filter) Discover {
33+
// newFilteredDiscoverer creates a discoverer that applies the specified filter to the returned entities of the discoverer
34+
func newFilteredDiscoverer(logger logger.Interface, applyTo Discover, filter Filter) Discover {
3535
return filtered{
3636
Discover: applyTo,
3737
logger: logger,

internal/discover/graphics.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131
"github.com/NVIDIA/nvidia-container-toolkit/internal/lookup/root"
3232
)
3333

34-
// NewDRMNodesDiscoverer returns a discoverrer for the DRM device nodes associated with the specified visible devices.
34+
// NewDRMNodesDiscoverer returns a discoverer for the DRM device nodes associated with the specified visible devices.
3535
//
3636
// TODO: The logic for creating DRM devices should be consolidated between this
3737
// and the logic for generating CDI specs for a single device. This is only used
@@ -140,7 +140,7 @@ func (d drmDevicesByPath) Hooks() ([]Hook, error) {
140140
return []Hook{hook}, nil
141141
}
142142

143-
// getSpecificLinkArgs returns the required specic links that need to be created
143+
// getSpecificLinkArgs returns the required specific links that need to be created
144144
func (d drmDevicesByPath) getSpecificLinkArgs(devices []Device) ([]string, error) {
145145
selectedDevices := make(map[string]bool)
146146
for _, d := range devices {
@@ -185,13 +185,13 @@ func newDRMDeviceDiscoverer(logger logger.Interface, devices image.VisibleDevice
185185
},
186186
)
187187

188-
filter, err := newDRMDeviceFilter(logger, devices, devRoot)
188+
filter, err := newDRMDeviceFilter(devices, devRoot)
189189
if err != nil {
190190
return nil, fmt.Errorf("failed to construct DRM device filter: %v", err)
191191
}
192192

193193
// We return a discoverer that applies the DRM device filter created above to all discovered DRM device nodes.
194-
d := newFilteredDisoverer(
194+
d := newFilteredDiscoverer(
195195
logger,
196196
allDevices,
197197
filter,
@@ -201,7 +201,7 @@ func newDRMDeviceDiscoverer(logger logger.Interface, devices image.VisibleDevice
201201
}
202202

203203
// newDRMDeviceFilter creates a filter that matches DRM devices nodes for the visible devices.
204-
func newDRMDeviceFilter(logger logger.Interface, devices image.VisibleDevices, devRoot string) (Filter, error) {
204+
func newDRMDeviceFilter(devices image.VisibleDevices, devRoot string) (Filter, error) {
205205
gpuInformationPaths, err := proc.GetInformationFilePaths(devRoot)
206206
if err != nil {
207207
return nil, fmt.Errorf("failed to read GPU information: %v", err)
@@ -290,7 +290,7 @@ func newXorgDiscoverer(logger logger.Interface, driver *root.Driver, nvidiaCTKPa
290290
nvidiaCTKPath: nvidiaCTKPath,
291291
}
292292

293-
xorgConfg := NewMounts(
293+
xorgConfig := NewMounts(
294294
logger,
295295
lookup.NewFileLocator(
296296
lookup.WithLogger(logger),
@@ -303,7 +303,7 @@ func newXorgDiscoverer(logger logger.Interface, driver *root.Driver, nvidiaCTKPa
303303

304304
d := Merge(
305305
xorgLibs,
306-
xorgConfg,
306+
xorgConfig,
307307
xorgHooks,
308308
)
309309

0 commit comments

Comments
 (0)