diff --git a/tests/e2e/nvidia-container-toolkit_test.go b/tests/e2e/nvidia-container-toolkit_test.go index d7830a873..0331c8236 100644 --- a/tests/e2e/nvidia-container-toolkit_test.go +++ b/tests/e2e/nvidia-container-toolkit_test.go @@ -430,14 +430,16 @@ EOF`) }) It("should not fail when using the nvidia-container-runtime", func(ctx context.Context) { - _, _, err := runner.Run("docker run --rm --runtime=nvidia -e NVIDIA_VISIBLE_DEVICES=all -e NVIDIA_DRIVER_CAPABILITIES=all firmware-test") + output, _, err := runner.Run("docker run --rm --runtime=nvidia -e NVIDIA_VISIBLE_DEVICES=all -e NVIDIA_DRIVER_CAPABILITIES=all firmware-test") Expect(err).ToNot(HaveOccurred()) + Expect(output).To(BeEmpty()) }) - It("should fail when using the nvidia-container-runtime-hook", Label("legacy"), func(ctx context.Context) { - _, stderr, err := runner.Run("docker run --rm --runtime=runc --gpus=all firmware-test") - Expect(err).To(HaveOccurred()) - Expect(stderr).To(ContainSubstring(": mount error: path error: /lib/firmware/nvidia/")) + // TODO: Note that this requires Docker >= 29.2.0 + It("should not fail when using the --gpus flag", Label("legacy"), func(ctx context.Context) { + output, _, err := runner.Run("docker run --rm --runtime=runc --gpus=all firmware-test") + Expect(err).ToNot(HaveOccurred()) + Expect(output).To(BeEmpty()) }) })