Skip to content

🐛[BUG]: UNet example not working with model.save() because of name clashes #1177

@CharlelieLrt

Description

@CharlelieLrt

Version

1.2.0

On which installation method(s) does this occur?

No response

Describe the issue

Problem

@nbren reported that the UNet example in the documentation is not working with model.save() because of some clashes with the UNet class shipped in the physicsnemo model zoo.

It is unclear why the names are clashing. Is it because it is not possible to define a subclass of physicsnemo.Module whose class.__name__ is already in the model registry?

Solution

  • If names clashes cannot be avoided, this should at least be documented, and the error message should be improved to be more informative on the reason of the clash.

Minimum reproducible example

Relevant log output

Environment details

Metadata

Metadata

Assignees

Labels

DocumentationImprovements or additions to documentationbugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions