Skip to content

Conversation

@CharlelieLrt
Copy link
Collaborator

PhysicsNeMo Pull Request

Description

Adds zip and unzip to docker file.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

Signed-off-by: Charlelie Laurent <[email protected]>
@CharlelieLrt
Copy link
Collaborator Author

/blossom-ci

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR adds the zip and unzip command-line utilities to the PhysicsNeMo Docker image. The change modifies the builder stage's apt-get install command to include these two compression tools alongside existing dependencies (git-lfs, graphviz, libgl1). Since the builder stage serves as the base for all downstream stages (ci, deploy, docs), these utilities become available throughout the container lifecycle. This is a practical addition for a scientific computing framework that likely handles compressed datasets and archives, enabling users to work with .zip files directly within the containerized environment without requiring additional manual installation steps.

Important Files Changed

Filename Score Overview
Dockerfile 5/5 Added zip and unzip to the apt-get install command in the builder stage

Confidence score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects a trivial addition of standard system utilities with no code logic changes, dependency conflicts, or breaking potential
  • No files require special attention

Sequence Diagram

sequenceDiagram
    participant User
    participant Docker Build
    participant apt-get
    participant Base Container
    
    User->>Docker Build: "docker build"
    Docker Build->>Base Container: "Pull nvcr.io/nvidia/pytorch:25.09-py3"
    Base Container-->>Docker Build: "Base image ready"
    Docker Build->>apt-get: "apt-get update"
    apt-get-->>Docker Build: "Package lists updated"
    Docker Build->>apt-get: "apt-get install -y git-lfs graphviz libgl1 zip unzip"
    apt-get-->>Docker Build: "Packages installed (including zip and unzip)"
    Docker Build->>Docker Build: "Continue with remaining build stages"
    Docker Build-->>User: "Image build complete"
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Collaborator

@ktangsali ktangsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@CharlelieLrt CharlelieLrt merged commit a1ff9d2 into NVIDIA:main Oct 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants