Update GraphCast for model standards#1358
Merged
pzharrington merged 6 commits intoNVIDIA:mainfrom Feb 3, 2026
Merged
Conversation
Contributor
Greptile OverviewGreptile SummaryThis PR successfully updates GraphCast to comply with model standards while making necessary refactoring changes. The main model file now includes comprehensive docstrings with detailed shape annotations using jaxtyping (compatible since Key improvements include:
All tests are reportedly passing, and the changes maintain backward compatibility at the functional level while cleaning up the API surface. Important Files Changed
|
mnabian
reviewed
Jan 29, 2026
mnabian
reviewed
Jan 29, 2026
mnabian
approved these changes
Jan 29, 2026
Collaborator
mnabian
left a comment
There was a problem hiding this comment.
LGTM! Left a couple of comments.
Collaborator
Author
|
/blossom-ci |
Collaborator
Author
|
/blossom-ci |
dallasfoster
approved these changes
Jan 30, 2026
Collaborator
Author
|
/blossom-ci |
Collaborator
Author
|
/blossom-ci |
1 similar comment
Collaborator
Author
|
/blossom-ci |
ktangsali
approved these changes
Feb 3, 2026
Collaborator
ktangsali
left a comment
There was a problem hiding this comment.
Changes to the toml file look good!
coreyjadams
pushed a commit
to coreyjadams/physicsnemo
that referenced
this pull request
Feb 6, 2026
* Update for model standards * Migrate loss to metrics * format * Fix CI test
coreyjadams
pushed a commit
to coreyjadams/physicsnemo
that referenced
this pull request
Feb 6, 2026
* Update for model standards * Migrate loss to metrics * format * Fix CI test
coreyjadams
pushed a commit
to coreyjadams/physicsnemo
that referenced
this pull request
Feb 6, 2026
* Update for model standards * Migrate loss to metrics * format * Fix CI test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Updates GraphCast to comply with model standards, along with misc fixes:
multimesh_leveloptiondglreferenceTests are passing; transformer_engine dependency still needs to be worked out.
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.