Skip to content

Fixes Mesh README broken links#1605

Merged
peterdsharpe merged 1 commit intoNVIDIA:mainfrom
peterdsharpe:psharpe/mesh-readme-fix
Apr 29, 2026
Merged

Fixes Mesh README broken links#1605
peterdsharpe merged 1 commit intoNVIDIA:mainfrom
peterdsharpe:psharpe/mesh-readme-fix

Conversation

@peterdsharpe
Copy link
Copy Markdown
Collaborator

  • Introduced scripts to render the PyVista stock airplane mesh with Gaussian and mean curvature visualizations, saving outputs as PNG images.
  • Updated README to reflect new image paths for the airplane mesh and curvature visualizations.
  • Added a plain wireframe rendering of the airplane mesh for basic visualization.

These additions enhance the documentation and provide visual examples for curvature computations in the physicsnemo mesh module.

PhysicsNeMo Pull Request

Description

Closes #1537

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

- Introduced scripts to render the PyVista stock airplane mesh with Gaussian and mean curvature visualizations, saving outputs as PNG images.
- Updated README to reflect new image paths for the airplane mesh and curvature visualizations.
- Added a plain wireframe rendering of the airplane mesh for basic visualization.

These additions enhance the documentation and provide visual examples for curvature computations in the physicsnemo mesh module.
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 28, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@peterdsharpe peterdsharpe requested a review from mnabian April 28, 2026 18:56
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 28, 2026

Greptile Summary

This PR fixes broken image and module links in physicsnemo/mesh/README.md by replacing repo-root-relative paths with paths relative to the README's own directory, and adds three documentation scripts (docs/img/mesh/airplane*.py) along with their rendered PNG outputs to serve as the new image sources.

Important Files Changed

Filename Overview
physicsnemo/mesh/README.md Fixes broken image links and module links by switching from repo-root-relative paths to paths relative to the README's directory; renames physicsnemo.mesh.examplesphysicsnemo.mesh.primitives in the module listing.
docs/img/mesh/airplane.py New script generating the plain wireframe airplane PNG; straightforward and correct.
docs/img/mesh/airplane_gaussian_curvature.py Generates Gaussian curvature visualization; includes a 50-iteration Python-loop Laplacian smoother that is functional but slow for docs generation.
docs/img/mesh/airplane_mean_curvature.py Generates mean curvature visualization; mirrors the Gaussian curvature script with the same smoothing loop pattern.

Reviews (1): Last reviewed commit: "Add airplane mesh visualizations and cur..." | Re-trigger Greptile

@mnabian
Copy link
Copy Markdown
Collaborator

mnabian commented Apr 28, 2026

@peterdsharpe LGTM in overall. I'm just concerned about the placement of the .py files in the docs folder. Should those be moved to the relevant recipe in the examples directory?

@peterdsharpe
Copy link
Copy Markdown
Collaborator Author

No, those are intended to be there - those are just minimal scripts to generate the images themselves, so I like having those right next to the images (in case we want to later regenerate them.)

The same behavior has lots of examples in /examples/minimal/mesh and in the API docs, so user are covered there :)

Copy link
Copy Markdown
Collaborator

@mnabian mnabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterdsharpe peterdsharpe enabled auto-merge April 28, 2026 19:09
@peterdsharpe
Copy link
Copy Markdown
Collaborator Author

/blossom-ci

@peterdsharpe peterdsharpe added this pull request to the merge queue Apr 29, 2026
Merged via the queue into NVIDIA:main with commit a8a0739 Apr 29, 2026
4 checks passed
@peterdsharpe peterdsharpe deleted the psharpe/mesh-readme-fix branch April 29, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛[BUG]: Broken links in Mesh README.md

2 participants