fix: migration bug, and units from new defaults

Author: lockwobr

.github/workflows/operator-container.yaml

@@ -27,7 +27,7 @@ on:
 env:
   REGISTRY: ghcr.io
   IMAGE_NAME: ${{ github.repository }}
-  GO_VERSION: 1.23.4
+  GO_VERSION: 1.23.6
 
 # There is a single job in this workflow. It's configured to run on the latest available version of Ubuntu.
 jobs:

k8s-tests/chainsaw/skyhook/config-skyhook/skyhook.yaml

@@ -18,6 +18,11 @@ spec:
       interrupt: 
         type: service
         services: [cron]
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -27,6 +32,11 @@ spec:
         game.properties:
           type: service
           services: [rsyslog]
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
       configMap:
         game.properties: |
           enemies=aliens
@@ -56,3 +66,8 @@ spec:
           color.bad=yellow
           allow.textmode=true
           how.nice.to.look=fairlyNice
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi

k8s-tests/chainsaw/skyhook/config-skyhook/update-no-interrupt.yaml

@@ -18,6 +18,11 @@ spec:
       interrupt: 
         type: service
         services: [cron]
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -32,6 +37,11 @@ spec:
           changed
         ui.properties: |
           changed
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     baxter:
       version: "3.2.1"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -43,4 +53,9 @@ spec:
         game.properties: |
           changed again
         ui.properties: |
-          changed
+          changed
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi

k8s-tests/chainsaw/skyhook/config-skyhook/update-while-running.yaml

@@ -18,6 +18,11 @@ spec:
       interrupt: 
         type: service
         services: [cron]
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -38,6 +43,11 @@ spec:
           color.bad=yellow
           allow.textmode=true
           how.nice.to.look=fairlyNice
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     baxter:
       version: "3.2.1"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -52,4 +62,9 @@ spec:
           color.good=purple
           color.bad=yellow
           allow.textmode=true
-          how.nice.to.look=fairlyNice
+          how.nice.to.look=fairlyNice
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi

k8s-tests/chainsaw/skyhook/config-skyhook/update.yaml

@@ -18,6 +18,11 @@ spec:
       interrupt: 
         type: service
         services: [cron]
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -35,6 +40,11 @@ spec:
           color.bad=yellow
           allow.textmode=true
           how.nice.to.look=fairlyNice
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     baxter:
       version: "3.2.1"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -49,4 +59,9 @@ spec:
           color.good=purple
           color.bad=yellow
           allow.textmode=true
-          how.nice.to.look=fairlyNice
+          how.nice.to.look=fairlyNice
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi

k8s-tests/chainsaw/skyhook/failure-skyhook/chainsaw-test.yaml

@@ -6,7 +6,7 @@ metadata:
 spec:
   concurrent: true 
   timeouts:
-    assert: 120s
+    assert: 240s
   catch: ## if errors, print the most important info
   - get:
       apiVersion: v1

k8s-tests/chainsaw/skyhook/interrupt-grouping/skyhook.yaml

@@ -14,7 +14,6 @@ spec:
     - key: nvidia.com/gpu
       operator: Exists
   packages:
-    spenser:
     zeb:
       version: "2.1.4"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -24,6 +23,11 @@ spec:
       interrupt: 
         type: service
         services: [cron]
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     dax:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -34,4 +38,7 @@ spec:
         type: service
         services: [containerd, foobar]
       resources:
-        cpuLimit: 523m
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi

k8s-tests/chainsaw/skyhook/interrupt/skyhook.yaml

@@ -22,13 +22,23 @@ spec:
       agentImageOverride: ghcr.io/nvidia/skyhook/agentless:3.2.3
       env: 
         - name: SLEEP_LEN
-          value: "8" ## making slow
+          value: "8" ## making slower
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     spencer:
       version: "3.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
       env: 
         - name: SLEEP_LEN
           value: "3" ## making faster
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
       dependsOn:
         dexter: "1.2.3"
     foobar:
@@ -37,6 +47,11 @@ spec:
       dependsOn:
         dexter: "1.2.3"
         baxter: "3.3"
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     baxter: 
       version: "3.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -48,6 +63,11 @@ spec:
         services: [rsyslog]
       dependsOn:
         spencer: "3.2.3"
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi
     dexter:
       version: "1.2.3"
       image: ghcr.io/nvidia/skyhook/agentless
@@ -68,3 +88,8 @@ spec:
           color.bad=yellow
           allow.textmode=true
           how.nice.to.look=fairlyNice
+      resources:
+        cpuLimit: 50m
+        cpuRequest: 50m
+        memoryLimit: 32Mi
+        memoryRequest: 32Mi

k8s-tests/chainsaw/skyhook/pod-finalizer/chainsaw-test.yaml

@@ -4,9 +4,9 @@ kind: Test
 metadata:
   name: pod-finalization
 spec:
-  concurrent: true ## TODO: fix this
+  concurrent: true
   timeouts:
-    assert: 60s
+    assert: 180s
   steps:
   - try:
     - script:

k8s-tests/chainsaw/skyhook/runtime-required/chainsaw-test.yaml

@@ -6,7 +6,7 @@ metadata:
 spec:
   concurrent: false 
   timeouts:
-    assert: 180s
+    assert: 240s
   catch: ## if errors, print the most important info
   - get:
       apiVersion: v1