Skip to content

Commit 138a4c5

Browse files
committed
fix issue
Signed-off-by: YanxuanLiu <[email protected]>
1 parent 850ad1e commit 138a4c5

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/shell-check.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,10 @@ jobs:
3232
uses: NVIDIA/spark-rapids-common/shell-check@main
3333
with:
3434
excluded_codes:
35-
SC2181
35+
SC2181,
36+
SC1090
3637

3738
# code explanation:
3839
# SC2181: note: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
40+
# SC1090: warning: ShellCheck can't follow non-constant source. Use a directive to specify location. [SC1090]
3941

python/benchmark/databricks/benchmark_utils.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ run_bm() {
8282

8383
algorithm=$1
8484

85-
params_delimited=$( echo $@ | sed -e 's/^/"/g' | sed -e 's/$/"/g' | sed -e 's/ /", "/g' )
85+
params_delimited=$( echo "$@" | sed -e 's/^/"/g' | sed -e 's/$/"/g' | sed -e 's/ /", "/g' )
8686

8787
json_string=`cat <<EOF
8888
{
@@ -132,7 +132,7 @@ EOF
132132
echo -n "."
133133
if [[ $TIME_LIMIT != "" ]] && (( duration > TIME_LIMIT ))
134134
then
135-
echo "\ntime limit of $TIME_LIMIT minutes exceeded, canceling run"
135+
printf "\ntime limit of $TIME_LIMIT minutes exceeded, canceling run\n"
136136
databricks jobs cancel-run $run_id --profile $DB_PROFILE
137137
fi
138138
sleep 10

0 commit comments

Comments
 (0)