fix: address review findings — double walk, N captures, short prefix, bash doc

- validate_local_path: single directory walk instead of two rglob passes
- srtctl check: capture fingerprint once, reuse for all worker comparisons
- model.revision: require >= 7 chars to prevent false prefix matches
- Document bash requirement for process substitution in heredoc script

Author: alec-flowers

src/srtctl/cli/submit.py

@@ -41,7 +41,13 @@
     load_config,
     resolve_config_with_defaults,
 )
-from srtctl.core.fingerprint import check_against_fingerprint, diff_fingerprints, format_check_results, format_diff
+from srtctl.core.fingerprint import (
+    capture_fingerprint,
+    check_against_fingerprint,
+    diff_fingerprints,
+    format_check_results,
+    format_diff,
+)
 from srtctl.core.lockfile import load_lockfile_fingerprints
 from srtctl.core.schema import SrtConfig
 from srtctl.core.status import create_job_record
@@ -1053,10 +1059,11 @@ def add_common_args(p):
             console.print(f"[bold red]Could not load fingerprints from:[/] {args.path}")
             sys.exit(1)
 
-        # Check each worker's fingerprint against current environment
+        # Capture current environment once, reuse for all worker checks
+        current_fp = capture_fingerprint()
         all_results = []
         for worker in sorted(fps.keys()):
-            results = check_against_fingerprint(fps[worker])
+            results = check_against_fingerprint(fps[worker], current_fp)
             if results:
                 all_results.extend(results)
                 console.print(f"\n[bold]{worker}:[/]")

src/srtctl/core/fingerprint.py

@@ -647,7 +647,7 @@ def verify_identity(
                     )
                 )
 
-        if identity.model.revision:
+        if identity.model.revision and len(identity.model.revision) >= 7:
             fp_rev = fp_model.get("hf_revision")
             if fp_rev and fp_rev.startswith(identity.model.revision):
                 results.append(IdentityCheckResult("model.revision", True, f"{fp_rev[:12]}"))
@@ -878,8 +878,10 @@ def env_vars():
 Path('{output_path}').parent.mkdir(parents=True, exist_ok=True)
 Path('{output_path}').write_text(json.dumps(fp, indent=2) + '\\n')
 """
-    # Use a heredoc to write the script to a temp file, then execute it.
+    # Use a heredoc via process substitution to pass the script to python3.
     # This is immune to quoting/escaping issues in the bash → srun chain.
+    # NOTE: <(...) requires bash (not POSIX sh/dash). srun containers use bash.
+    # The || true suffix means non-bash shells silently skip fingerprinting.
     return f"python3 <(cat <<'__FINGERPRINT_EOF__'\n{script}__FINGERPRINT_EOF__\n) || true"
 
 

src/srtctl/core/validation.py

@@ -43,9 +43,13 @@ def validate_local_path(name: str, path: str) -> ValidationResult:
         if not p.exists():
             return ValidationResult(name, False, f"not found: {path}")
         if p.is_dir():
-            file_count = sum(1 for _ in p.rglob("*") if _.is_file())
-            total_gb = sum(f.stat().st_size for f in p.rglob("*") if f.is_file()) / 1e9
-            return ValidationResult(name, True, f"{file_count} files, {total_gb:.1f}GB")
+            file_count = 0
+            total_bytes = 0
+            for f in p.rglob("*"):
+                if f.is_file():
+                    file_count += 1
+                    total_bytes += f.stat().st_size
+            return ValidationResult(name, True, f"{file_count} files, {total_bytes / 1e9:.1f}GB")
         size_gb = p.stat().st_size / 1e9
         return ValidationResult(name, True, f"{size_gb:.1f}GB")
     except Exception as e: