cleanup: remove dead container_image/digest/name fields from ModelConfig

- Removed name, revision, container_image, container_digest from ModelConfig
  (all moved to identity block)
- Removed Docker image pre-submit validation (can't verify from inside Pyxis)
- HF validation now reads from identity.model.repo
- Updated tests to use IdentityConfig instead of old ModelConfig fields
- Note: background validation thread was effectively dead code — daemon thread
  exits before HTTP completes. Left in place but it needs a rethink.

Author: alec-flowers

recipes/mocker/kimi-trace-agg.yaml

@@ -5,9 +5,7 @@ slurm:
 
 model:
   path: "kimi-k25-nvfp4"
-  name: "nvidia/Kimi-K2.5-NVFP4"  # HuggingFace model ID (virtual identity for reproducibility)
   container: "trtllm-runtime"
-  container_image: "gitlab-master.nvidia.com:5005/dl/ai-dynamo/dynamo:56f877977-trtllm-arm64"  # pullable Docker URI
   precision: "fp4"
 
 resources:

src/srtctl/core/schema.py

@@ -385,12 +385,6 @@ class ModelConfig:
     container: str
     precision: str
 
-    # Virtual identity (optional, for reproducibility and lockfile)
-    name: str | None = None  # HuggingFace model ID, e.g. "deepseek-ai/DeepSeek-R1"
-    revision: str | None = None  # HuggingFace git commit SHA
-    container_image: str | None = None  # Docker image tag, e.g. "lmsysorg/sglang:v0.4.6"
-    container_digest: str | None = None  # Docker manifest digest, e.g. "sha256:abc..."
-
     Schema: ClassVar[type[Schema]] = Schema
 
 

src/srtctl/core/validation.py

@@ -143,29 +143,17 @@ def run_all_validations(config: SrtConfig) -> list[ValidationResult]:
     except Exception as e:
         results.append(ValidationResult("container_path", False, f"check failed: {e}"))
 
-    # HuggingFace model — check identity block first, fall back to model config
+    # HuggingFace model (from identity block)
     try:
         hf_repo = None
         hf_rev = None
         if hasattr(config, "identity") and config.identity and config.identity.model:
             hf_repo = config.identity.model.repo
             hf_rev = config.identity.model.revision
-        if not hf_repo and hasattr(config.model, "name"):
-            hf_repo = config.model.name
-        if not hf_rev and hasattr(config.model, "revision"):
-            hf_rev = config.model.revision
         results.append(validate_hf_model(hf_repo, hf_rev))
     except Exception as e:
         results.append(ValidationResult("hf_model", False, f"check failed: {e}"))
 
-    # Docker image (if set on model config)
-    try:
-        container_image = getattr(config.model, "container_image", None)
-        container_digest = getattr(config.model, "container_digest", None)
-        results.append(validate_docker_image(container_image, container_digest))
-    except Exception as e:
-        results.append(ValidationResult("docker_image", False, f"check failed: {e}"))
-
     return results
 
 

tests/test_configs.py

@@ -93,63 +93,53 @@ def test_decode_nodes_zero_inherits_tp_from_prefill(self):
         assert total_needed <= total_available
 
 
-class TestModelConfigIdentity:
-    """Tests for optional virtual identity fields on ModelConfig."""
+class TestIdentityConfig:
+    """Tests for the identity block (virtual identity for runtime verification)."""
 
-    def test_optional_fields_default_to_none(self):
-        """All identity fields are None when not specified."""
-        from srtctl.core.schema import ModelConfig
+    def test_defaults_to_empty(self):
+        """IdentityConfig has empty defaults."""
+        from srtctl.core.schema import IdentityConfig
 
-        config = ModelConfig(path="/model", container="/c.sqsh", precision="fp8")
-        assert config.name is None
-        assert config.revision is None
-        assert config.container_image is None
-        assert config.container_digest is None
+        config = IdentityConfig()
+        assert config.model.repo is None
+        assert config.model.revision is None
+        assert config.frameworks == {}
 
-    def test_optional_fields_when_specified(self):
-        """Identity fields are set when provided."""
-        from srtctl.core.schema import ModelConfig
+    def test_with_values(self):
+        """IdentityConfig stores model and framework info."""
+        from srtctl.core.schema import IdentityConfig, IdentityModelConfig
 
-        config = ModelConfig(
-            path="/model",
-            container="/c.sqsh",
-            precision="fp4",
-            name="deepseek-ai/DeepSeek-R1",
-            revision="e4e908c07378",
-            container_image="lmsysorg/sglang:v0.4.6.post1",
-            container_digest="sha256:abc123",
+        config = IdentityConfig(
+            model=IdentityModelConfig(repo="nvidia/Kimi-K2.5-NVFP4", revision="abc123"),
+            frameworks={"dynamo": "1.0.0", "tensorrt_llm": "1.3.0rc9"},
         )
-        assert config.name == "deepseek-ai/DeepSeek-R1"
-        assert config.revision == "e4e908c07378"
-        assert config.container_image == "lmsysorg/sglang:v0.4.6.post1"
-        assert config.container_digest == "sha256:abc123"
+        assert config.model.repo == "nvidia/Kimi-K2.5-NVFP4"
+        assert config.model.revision == "abc123"
+        assert config.frameworks["dynamo"] == "1.0.0"
+        assert config.frameworks["tensorrt_llm"] == "1.3.0rc9"
 
     def test_marshmallow_roundtrip(self):
         """Schema dump/load preserves identity fields."""
-        from srtctl.core.schema import ModelConfig
+        from srtctl.core.schema import IdentityConfig, IdentityModelConfig
 
-        original = ModelConfig(
-            path="/model",
-            container="/c.sqsh",
-            precision="fp4",
-            name="deepseek-ai/DeepSeek-R1",
-            revision="abc123",
+        original = IdentityConfig(
+            model=IdentityModelConfig(repo="nvidia/Kimi-K2.5-NVFP4", revision="abc123"),
+            frameworks={"dynamo": "1.0.0"},
         )
-        schema = ModelConfig.Schema()
+        schema = IdentityConfig.Schema()
         dumped = schema.dump(original)
         loaded = schema.load(dumped)
-        assert loaded.name == "deepseek-ai/DeepSeek-R1"
-        assert loaded.revision == "abc123"
-        assert loaded.container_image is None  # was not set
+        assert loaded.model.repo == "nvidia/Kimi-K2.5-NVFP4"
+        assert loaded.frameworks["dynamo"] == "1.0.0"
 
-    def test_marshmallow_load_ignores_missing_optional(self):
-        """Loading YAML without identity fields still works."""
+    def test_model_config_is_clean(self):
+        """ModelConfig has no virtual identity fields (moved to IdentityConfig)."""
         from srtctl.core.schema import ModelConfig
 
-        data = {"path": "/model", "container": "/c.sqsh", "precision": "fp8"}
-        loaded = ModelConfig.Schema().load(data)
-        assert loaded.name is None
-        assert loaded.revision is None
+        config = ModelConfig(path="/model", container="/c.sqsh", precision="fp8")
+        assert not hasattr(config, "name")
+        assert not hasattr(config, "container_image")
+        assert not hasattr(config, "container_digest")
 
 
 class TestDynamoConfig:

tests/test_validation.py

@@ -200,10 +200,11 @@ def test_all_checks_produce_results(self):
                 "path": "/nonexistent",
                 "container": "/nonexistent.sqsh",
                 "precision": "fp8",
-                "name": "some/model",
-                "container_image": "some/image:tag",
             },
             "resources": {"gpu_type": "h100", "gpus_per_node": 8, "prefill_nodes": 1, "decode_nodes": 1},
+            "identity": {
+                "model": {"repo": "some/model"},
+            },
         })
 
         with patch("srtctl.core.validation.requests.head", side_effect=requests.ConnectionError()):
@@ -213,7 +214,6 @@ def test_all_checks_produce_results(self):
         assert "model_path" in check_names
         assert "container_path" in check_names
         assert "hf_model" in check_names
-        assert "docker_image" in check_names
 
 
 # ============================================================================