review: harden fingerprint PR after code review

- IdentityCheckResult now frozen (consistency with other dataclasses)
- Extract FRAMEWORK_PACKAGES constant (eliminates hardcoded duplicates)
- Remove hasattr(config, 'identity') checks (field always exists via default_factory)
- Reduce HF validation timeout 5s -> 2s (air-gapped clusters)
- Reduce bash script probe timeout 5s -> 3s (faster worker startup)
- Simplify find_python() (Path.exists() instead of subprocess)

Author: alec-flowers

src/srtctl/cli/mixins/benchmark_stage.py

@@ -101,7 +101,7 @@ def run_benchmark(
         self._identity_verification = None
         try:
             fingerprints = collect_worker_fingerprints(self.runtime.log_dir)
-            if fingerprints and hasattr(self.config, "identity"):
+            if fingerprints and self.config.identity:
                 self._identity_verification = verify_identity(self.config.identity, fingerprints)
                 banner = format_identity_verification(self._identity_verification, self.config.identity)
                 for line in banner.splitlines():

src/srtctl/cli/submit.py

@@ -270,13 +270,9 @@ def _print_running_summary(config: SrtConfig, console: Console) -> None:
     console.print(f"  Backend:   {config.backend_type}")
     console.print(f"  Benchmark: {config.benchmark.type}")
 
-    has_identity = (
-        hasattr(config, "identity")
-        and config.identity
-        and (
-            (config.identity.model and (config.identity.model.repo or config.identity.model.revision))
-            or config.identity.frameworks
-        )
+    has_identity = config.identity and (
+        (config.identity.model and (config.identity.model.repo or config.identity.model.revision))
+        or config.identity.frameworks
     )
     if has_identity:
         id_fields = []
@@ -362,7 +358,7 @@ def submit_with_orchestrator(
     )
 
     # Identity validation (inline, <1s) — runs for both dry-run and submit
-    if hasattr(config, "identity") and config.identity and config.identity.model and config.identity.model.repo:
+    if config.identity and config.identity.model and config.identity.model.repo:
         from srtctl.core.validation import validate_hf_model
 
         hf_result = validate_hf_model(config.identity.model.repo, config.identity.model.revision)

src/srtctl/core/fingerprint.py

@@ -40,6 +40,15 @@
 # Sentinel for probes that failed
 UNAVAILABLE = "unavailable"
 
+# Framework name -> pip package name mapping.
+# Used in both native Python probes and the bash capture script.
+FRAMEWORK_PACKAGES: dict[str, str] = {
+    "vllm": "vllm",
+    "sglang": "sglang",
+    "tensorrt_llm": "tensorrt-llm",
+    "dynamo": "ai-dynamo",
+}
+
 
 # ============================================================================
 # Data Types
@@ -253,12 +262,7 @@ def probe_frameworks() -> ProbeResult:
     GPU context.
     """
     versions: dict[str, str] = {}
-    for name, pkg in [
-        ("vllm", "vllm"),
-        ("sglang", "sglang"),
-        ("tensorrt_llm", "tensorrt-llm"),
-        ("dynamo", "ai-dynamo"),
-    ]:
+    for name, pkg in FRAMEWORK_PACKAGES.items():
         v = _run_cmd(f"python3 -c \"import importlib.metadata; print(importlib.metadata.version('{pkg}'))\"")
         if v:
             versions[name] = v
@@ -584,7 +588,7 @@ def check_against_fingerprint(
 # ============================================================================
 
 
-@dataclass
+@dataclass(frozen=True)
 class IdentityCheckResult:
     """Result of a single identity check."""
 
@@ -742,16 +746,16 @@ def generate_capture_script(output_path: str) -> str:
 from pathlib import Path
 from datetime import datetime, timezone
 
-def run(cmd, timeout=5):
+def run(cmd, timeout=3):
     try:
         r = subprocess.run(cmd, shell=True, capture_output=True, text=True, timeout=timeout)
         return r.stdout.strip() if r.returncode == 0 else None
     except Exception:
         return None
 
 def find_python():
-    for p in ['/opt/dynamo/venv/bin/python3', '/opt/venv/bin/python3', 'python3']:
-        if run(f'command -v {{0}} || test -x {{0}}'.format(p)):
+    for p in ['/opt/dynamo/venv/bin/python3', '/opt/venv/bin/python3']:
+        if Path(p).exists():
             return p
     return 'python3'
 
@@ -786,12 +790,7 @@ def framework_versions():
     # Use importlib.metadata for all packages — avoids loading native CUDA
     # extensions (tensorrt_llm, torch) which fail without GPU context.
     versions = {{}}
-    for name, pkg in [
-        ('vllm', 'vllm'),
-        ('sglang', 'sglang'),
-        ('tensorrt_llm', 'tensorrt-llm'),
-        ('dynamo', 'ai-dynamo'),
-    ]:
+    for name, pkg in [{", ".join(f"('{n}', '{p}')" for n, p in FRAMEWORK_PACKAGES.items())}]:
         v = run(f"{{PY}} -c \\"import importlib.metadata; print(importlib.metadata.version('{{pkg}}'))\\"".format(PY=PY, pkg=pkg))
         if v:
             versions[name] = v

src/srtctl/core/validation.py

@@ -24,7 +24,7 @@
 
 logger = logging.getLogger(__name__)
 
-_HTTP_TIMEOUT = 5.0
+_HTTP_TIMEOUT = 2.0  # Fast enough for live networks, doesn't block long on air-gapped clusters
 
 
 @dataclass(frozen=True)
@@ -147,7 +147,7 @@ def run_all_validations(config: SrtConfig) -> list[ValidationResult]:
     try:
         hf_repo = None
         hf_rev = None
-        if hasattr(config, "identity") and config.identity and config.identity.model:
+        if config.identity and config.identity.model:
             hf_repo = config.identity.model.repo
             hf_rev = config.identity.model.revision
         results.append(validate_hf_model(hf_repo, hf_rev))