WIP: start repo-wide ruff cleanup

Author: ishandhanani

analysis/dashboard/pareto_tab.py

@@ -122,11 +122,10 @@ def _fmt_delta(pct):
         st.warning("Select exactly 2 points to compare. Clear selection and try again.")
 
     # Clear selection button (visible when any points are selected)
-    if len(points) >= 1:
-        if st.button("Clear selection", key="clear_pareto_selection"):
-            st.session_state.pareto_chart_gen += 1
-            st.session_state.pareto_swapped = False
-            st.rerun()
+    if len(points) >= 1 and st.button("Clear selection", key="clear_pareto_selection"):
+        st.session_state.pareto_chart_gen += 1
+        st.session_state.pareto_swapped = False
+        st.rerun()
 
     # Debug info for frontier
     if pareto_options["show_frontier"]:

analysis/srtlog/cache_manager.py

@@ -126,14 +126,7 @@ def save_to_cache(self, cache_name: str, data: pd.DataFrame | list[dict], source
             source_patterns: Glob patterns for source files
         """
         # Convert to DataFrame if needed
-        if isinstance(data, list):
-            if not data:
-                # Save empty DataFrame
-                df = pd.DataFrame()
-            else:
-                df = pd.DataFrame(data)
-        else:
-            df = data
+        df = (pd.DataFrame() if not data else pd.DataFrame(data)) if isinstance(data, list) else data
 
         # Save to parquet
         cache_file = self.cache_dir / f"{cache_name}.parquet"

analysis/srtlog/config_reader.py

@@ -34,19 +34,17 @@ def validate_config_structure(config: dict[str, Any], config_path: str) -> None:
         )
 
     # Validate nested structure
-    if "config" in config:
-        if "server_args" not in config["config"]:
-            logger.warning(
-                f"Config at {config_path} missing 'server_args' in 'config'. "
-                f"Available keys in config: {list(config['config'].keys())}"
-            )
+    if "config" in config and "server_args" not in config["config"]:
+        logger.warning(
+            f"Config at {config_path} missing 'server_args' in 'config'. "
+            f"Available keys in config: {list(config['config'].keys())}"
+        )
 
-    if "gpu_info" in config:
-        if "gpus" not in config["gpu_info"]:
-            logger.warning(
-                f"Config at {config_path} missing 'gpus' in 'gpu_info'. "
-                f"Available keys: {list(config['gpu_info'].keys())}"
-            )
+    if "gpu_info" in config and "gpus" not in config["gpu_info"]:
+        logger.warning(
+            f"Config at {config_path} missing 'gpus' in 'gpu_info'. "
+            f"Available keys: {list(config['gpu_info'].keys())}"
+        )
 
 
 def read_config_file(config_path: str) -> NodeConfig | None:

analysis/srtlog/visualizations.py

@@ -291,10 +291,7 @@ def create_node_metric_graph(
                 continue
 
             # Extract value
-            if value_extractor:
-                value = value_extractor(batch)
-            else:
-                value = batch.get(metric_key)
+            value = value_extractor(batch) if value_extractor else batch.get(metric_key)
 
             if value is not None:
                 timestamps.append(batch["timestamp"])
@@ -516,11 +513,10 @@ def calculate_pareto_frontier(df: pd.DataFrame, y_metric: str = "Output TPS/GPU"
 
         # Check if this point is dominated by any other point
         for j, (x2, y2) in enumerate(points):
-            if i != j:
+            if i != j and x2 >= x1 and y2 >= y1 and (x2 > x1 or y2 > y1):
                 # Point (x2, y2) dominates (x1, y1) if it's better in both dimensions
-                if x2 >= x1 and y2 >= y1 and (x2 > x1 or y2 > y1):
-                    is_dominated = True
-                    break
+                is_dominated = True
+                break
 
         if not is_dominated:
             frontier.append((x1, y1))