Skip to content

Commit e5f560f

Browse files
committed
Fix vswhere.exe discovery for non-default Visual Studio installations
Closes #1235 Signed-off-by: Aditya kumar singh <143548997+Adityakk9031@users.noreply.github.com>
1 parent 4fec85d commit e5f560f

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

warp/_src/build_dll.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,10 @@ def find_host_compiler() -> str:
200200
print("Warning: VCToolsVersion not set after running vcvars64.bat")
201201
return ""
202202
cl_version = vc_tools_version.split(".")
203+
if len(cl_version) < 2:
204+
if verbose_cmd:
205+
print(f"Warning: Invalid VCToolsVersion format: {vc_tools_version}")
206+
return ""
203207

204208
# ensure at least VS2019 version, see list of MSVC versions here https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B
205209
cl_required_major = 14

0 commit comments

Comments
 (0)