Skip to content

Commit af0a285

Browse files
TylerMatteodhochbaum-dcp
TylerMatteo
and
dhochbaum-dcp
authored
Merging agency website link updates to master for prod release (#1279)
* Updated sketch url to DO * Updated nyc.gov/planning links * Updated special district crosswalk to reflect updated anchors --------- Co-authored-by: David Hochbaum <[email protected]>
1 parent 9191fb8 commit af0a285

File tree

14 files changed

+128
-128
lines changed

14 files changed

+128
-128
lines changed

‎app/components/layer-record-views/special-purpose-district.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ const { specialDistrictCrosswalk } = config;
66
export default class SpecialPurposeDistrictRecordComponent extends LayerRecordComponent {
77
get readMoreLink() {
88
const name = this.model.sdname;
9-
const [, [anchorName, boroName]] = specialDistrictCrosswalk.find(
9+
const [, [anchorName]] = specialDistrictCrosswalk.find(
1010
([dist]) => dist === name
1111
) || [[], []];
12-
return `https://www1.nyc.gov/site/planning/zoning/districts-tools/special-purpose-districts-${boroName}.page#${anchorName}`;
12+
return `https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/special-purpose-districts#${anchorName}`;
1313
}
1414
}

‎app/components/layer-record-views/special-purpose-subdistrict.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ const { specialDistrictCrosswalk } = config;
66
export default class SpecialPurposeDistrictRecordComponent extends LayerRecordComponent {
77
get readMoreLink() {
88
const name = this.model.sdname;
9-
const [, [anchorName, boroName]] = specialDistrictCrosswalk.find(
9+
const [, [anchorName]] = specialDistrictCrosswalk.find(
1010
([dist]) => dist === name
1111
) || [[], []];
1212

13-
return `https://www1.nyc.gov/site/planning/zoning/districts-tools/special-purpose-districts-${boroName}.page#${anchorName}`;
13+
return `https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/special-purpose-districts#${anchorName}`;
1414
}
1515
}

‎app/components/layer-record-views/tax-lot.js‎

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,15 @@ const specialPurposeDistrictsSQL = function (table, spdist1, spdist2, spdist3) {
1414

1515
const getPrimaryZone = (zonedist = '') => {
1616
if (!zonedist) return '';
17-
let primary = zonedist.match(/\w\d*/)[0].toLowerCase();
17+
18+
let primary = zonedist.match(/\w\d*/)[0];
19+
1820
// special handling for c1 and c2
19-
if (primary === 'c1' || primary === 'c2') primary = 'c1-c2';
21+
if (primary === 'C1' || primary === 'C2') primary = 'C1-C2';
2022
// special handling for c3 and c3a
21-
if (primary === 'c3' || primary === 'c3a') primary = 'c3-c3a';
23+
if (primary === 'C3' || primary === 'C3A') primary = 'C3-C3A';
24+
// special handling for r3
25+
if (primary === 'R3') primary = zonedist;
2226
return primary;
2327
};
2428

@@ -427,7 +431,7 @@ export default class TaxLotRecordComponent extends LayerRecordComponent {
427431

428432
get parentSpecialPurposeDistricts() {
429433
const DISTRICT_TOOLS_URL =
430-
'https://www1.nyc.gov/site/planning/zoning/districts-tools';
434+
'https://www.nyc.gov/content/planning/pages/zoning';
431435
const { spdist1, spdist2, spdist3 } = this.model;
432436

433437
return carto
@@ -479,9 +483,18 @@ export default class TaxLotRecordComponent extends LayerRecordComponent {
479483

480484
Object.keys(primaryZones).forEach((key) => {
481485
const value = primaryZones[key];
486+
const primaryZoneGroups = {
487+
R: 'residence-districts',
488+
C: 'commercial-districts',
489+
M: 'manufacturing-districts',
490+
};
491+
const primaryZoneGroup = primaryZoneGroups[value[0]]
492+
? primaryZoneGroups[value[0]]
493+
: '';
494+
482495
primaryZones[
483496
key
484-
] = `https://www1.nyc.gov/site/planning/zoning/districts-tools/${value}.page`;
497+
] = `https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/${primaryZoneGroup}/#${value}`;
485498
});
486499

487500
return {

‎app/components/layer-record-views/zoning-district.js‎

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,25 @@ export default class ZoningDistrictRecordComponent extends LayerRecordComponent
108108

109109
get primaryzoneURL() {
110110
const { primaryzone } = this;
111-
let url = '';
111+
let primary = primaryzone.toUpperCase();
112112

113-
if (primaryzone === 'c1' || primaryzone === 'c2') {
114-
url = 'c1-c2';
115-
} else if (primaryzone === 'c3') {
116-
url = 'c3-c3a';
117-
} else {
118-
url = primaryzone;
113+
if (primary === 'C1' || primary === 'C2') {
114+
primary = 'C1-C2';
115+
} else if (primary === 'C3' || primary === 'C3A') {
116+
primary = 'C3-C3A';
117+
} else if (primary === 'R3') {
118+
primary = zonedist;
119119
}
120120

121-
return url;
121+
const primaryZoneGroups = {
122+
R: 'residence-districts',
123+
C: 'commercial-districts',
124+
M: 'manufacturing-districts',
125+
};
126+
const primaryZoneGroup = primaryZoneGroups[primary[0]]
127+
? primaryZoneGroups[primary[0]]
128+
: '';
129+
130+
return `https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/${primaryZoneGroup}/#${primary}`;
122131
}
123132
}

‎app/templates/about.hbs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<p>
1919
For general zoning questions, read the
2020
<a
21-
href="https://www1.nyc.gov/site/planning/zoning/zoning-faq.page"
21+
href="https://www.nyc.gov/assets/planning/downloads/pdf/zoning/downloadable-zoning-resources/zoning-faq.pdf"
2222
target="_blank" rel="noopener noreferrer"
2323
>
2424
<strong>Zoning Help Desk FAQ</strong></a>.
@@ -30,7 +30,7 @@
3030
</a>
3131
during business hours (8:30AM–5:30PM, Monday–Friday, closed on legal holidays). Leave a detailed message with your block and lot information, and a zoning specialist will get back to you within two business days. Or fill out the
3232
<a
33-
href="https://www1.nyc.gov/site/planning/zoning/zoning-inquiry.page"
33+
href="https://www.nyc.gov/content/planning/pages/zoning#contact"
3434
target="_blank" rel="noopener noreferrer"
3535
>
3636
<strong>
@@ -59,11 +59,11 @@
5959
<p class="text-small">
6060
<em>
6161
ZoLa was developed by the City of New York using NYC open data and other public data sources and is provided solely for informational purposes. The City makes no representation as to the accuracy of the information or to its suitability for any purpose. The City disclaims any liability for errors that may be contained herein and shall not be responsible for any damages consequential or actual, arising out of or in connection with the use of this information. The City makes no warranties, express or implied, including, but not limited to, implied warranties of merchantability and fitness for a particular purpose as to the quality, content, accuracy, or completeness of the information, text graphics, links and other items contained in ZoLa. The text of the Zoning Resolution can be accessed
62-
<a href="http://www1.nyc.gov/site/planning/zoning/access-text.page">
62+
<a href="https://zoningresolution.planning.nyc.gov/">
6363
here
6464
</a>
6565
and the zoning maps can be accessed
66-
<a href="http://www1.nyc.gov/site/planning/zoning/index-map.page">
66+
<a href="https://zola.planning.nyc.gov/about?layer-groups=%5B%22building-footprints%22%2C%22commercial-overlays%22%2C%22street-centerlines%22%2C%22subway%22%2C%22tax-lots%22%2C%22zoning-districts%22%2C%22zoning-map-index%22%5D">
6767
here
6868
</a>
6969
.

‎app/templates/components/layer-record-views/commercial-overlay.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
</p>
1717
<p>
1818
<a
19-
href="https://www1.nyc.gov/site/planning/zoning/districts-tools/c1-c2-overlays.page"
19+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/commercial-districts#C1-C2-overlays"
2020
target="_blank" rel="noopener noreferrer"
2121
>
2222
<FaIcon @icon="external-link-alt" />

‎app/templates/components/layer-record-views/special-purpose-subdistrict.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
</p>
1414
<p>
1515
<a
16-
href="https://www1.nyc.gov/site/planning/zoning/districts-tools/special-purpose-districts-citywide.page"
16+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/special-purpose-districts#cw"
1717
target="_blank" rel="noopener noreferrer"
1818
>
1919
<FaIcon @icon="external-link-alt" />

‎app/templates/components/layer-record-views/tax-lot.hbs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@
194194
{{#if specialDistrict.anchorName}}
195195
<a
196196
target="_blank"
197-
href="https://www1.nyc.gov/site/planning/zoning/districts-tools/special-purpose-districts-{{specialDistrict.boroName}}.page#{{specialDistrict.anchorName}}"
197+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/special-purpose-districts#{{specialDistrict.anchorName}}"
198198
onclick={{action this.captureOutboundLink "Special Purpose District" preventDefault=false}}
199199
class="button" rel="noopener noreferrer"
200200
>
@@ -211,7 +211,7 @@
211211
{{#if this.model.overlay1}}
212212
<li>
213213
<a
214-
href="https://www1.nyc.gov/site/planning/zoning/districts-tools/c1-c2-overlays.page"
214+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/commercial-districts#C1-C2-overlays"
215215
target="_blank"
216216
class="button" rel="noopener noreferrer"
217217
>
@@ -223,7 +223,7 @@
223223
{{#if this.model.overlay2}}
224224
<li>
225225
<a
226-
href="https://www1.nyc.gov/site/planning/zoning/districts-tools/c1-c2-overlays.page"
226+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/commercial-districts#C1-C2-overlays"
227227
target="_blank"
228228
class="button" rel="noopener noreferrer"
229229
>

‎app/templates/components/layer-record-views/tax-lot/intersecting-layers-views.hbs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
<li>
4444
<a
4545
target="_blank"
46-
href="http://www1.nyc.gov/site/planning/zoning/districts-tools/waterfront-zoning.page#waterfront_access_plan" rel="noopener noreferrer"
46+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/rules-for-special-areas#waterfront-zoning" rel="noopener noreferrer"
4747
>
4848
<FaIcon @icon="external-link-alt" @transform="shrink-3 up-1" />
4949
Waterfront Access Plan
@@ -54,7 +54,7 @@
5454
<li>
5555
<a
5656
target="_blank"
57-
href="https://www1.nyc.gov/site/planning/zoning/districts-tools/waterfront-zoning.page" rel="noopener noreferrer"
57+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/rules-for-special-areas#waterfront-zoning" rel="noopener noreferrer"
5858
>
5959
<FaIcon @icon="external-link-alt" @transform="shrink-3 up-1" />
6060
Waterfront Block
@@ -65,7 +65,7 @@
6565
<li>
6666
<a
6767
target="_blank"
68-
href="https://www.nyc.gov/site/planning/planning-level/waterfront/wrp/wrp.page" rel="noopener noreferrer"
68+
href="https://www.nyc.gov/content/planning/pages/applicants/special-processes#wrp" rel="noopener noreferrer"
6969
>
7070
<FaIcon @icon="external-link-alt" @transform="shrink-3 up-1" />
7171
Coastal Zone
@@ -76,7 +76,7 @@
7676
<li>
7777
<a
7878
target="_blank"
79-
href="http://www1.nyc.gov/site/planning/zoning/districts-tools/lower-density-growth-mngmt.page" rel="noopener noreferrer"
79+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/rules-for-special-areas#lower-density-growth" rel="noopener noreferrer"
8080
>
8181
<FaIcon @icon="external-link-alt" @transform="shrink-3 up-1" />
8282
Lower Density Growth Management Zone
@@ -87,7 +87,7 @@
8787
<li>
8888
<a
8989
target="_blank"
90-
href="http://www1.nyc.gov/site/planning/zoning/districts-tools/flood-text.page" rel="noopener noreferrer"
90+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/rules-for-special-areas#flood" rel="noopener noreferrer"
9191
>
9292
<FaIcon @icon="external-link-alt" @transform="shrink-3 up-1" />
9393
Flood Zone
@@ -101,7 +101,7 @@
101101
<li>
102102
<a
103103
target="_blank"
104-
href="http://www1.nyc.gov/site/planning/zoning/districts-tools/flood-text.page" rel="noopener noreferrer"
104+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/rules-for-special-areas#flood" rel="noopener noreferrer"
105105
>
106106
<FaIcon @icon="external-link-alt" @transform="shrink-3 up-1" />
107107
Flood Zone
@@ -115,7 +115,7 @@
115115
<li>
116116
<a
117117
target="_blank"
118-
href="https://www1.nyc.gov/site/planning/plans/mih/mandatory-inclusionary-housing.page" rel="noopener noreferrer"
118+
href="https://www.nyc.gov/content/planning/pages/our-work/plans/citywide/mandatory-inclusionary-housing" rel="noopener noreferrer"
119119
>
120120
<FaIcon @icon="external-link-alt" @transform="shrink-3 up-1" />
121121
Mandatory Inclusionary Housing Area
@@ -137,7 +137,7 @@
137137
<li>
138138
<a
139139
target="_blank"
140-
href="http://www1.nyc.gov/site/planning/zoning/glossary.page#transit_zone" rel="noopener noreferrer"
140+
href="https://www.nyc.gov/assets/planning/downloads/pdf/zoning/downloadable-zoning-resources/zoning-glossary.pdf#page=34" rel="noopener noreferrer"
141141
>
142142
<FaIcon @icon="external-link-alt" @transform="shrink-3 up-1" />
143143
Appendix I

‎app/templates/components/layer-record-views/zoning-district.hbs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
{{#if (eq this.model.zonedist "BPC")}}
1111
<p>
1212
<a
13-
href="https://www1.nyc.gov/site/planning/zoning/districts-tools/special-purpose-districts-manhattan.page#battery_park"
13+
href="https://www.nyc.gov/content/planning/pages/zoning/zoning-districts-guide/special-purpose-districts#BPC"
1414
target="_blank"
1515
onclick={{action this.captureOutboundLink "Special Battery Park City"}} rel="noopener noreferrer"
1616
>
@@ -21,7 +21,7 @@
2121
{{else}}
2222
<p>
2323
<a
24-
href="https://www1.nyc.gov/site/planning/zoning/districts-tools/{{this.primaryzoneURL}}.page"
24+
href={{this.primaryzoneURL}}
2525
target="_blank"
2626
onclick={{action this.captureOutboundLink this.model.zonedist}} rel="noopener noreferrer"
2727
>

0 commit comments

Comments
 (0)