Outdated layer references for tax lot intersections

[TangoYankee]

Describe the bug
Intersecting layers feature is using expired table references to determine whether a layer intersects a tax lot

The file app/components/layer-record-views/tax-lot/intersecting-layers-views.js contains the carto table names for the layers of interest.

The tables are:

• inclusionary_housing alias to inclusionary_housing_v202007,
  • Production: present, does not sync
  • Staging: missing
  • Best guess at correct source: dcp_inclusionary_housing (though sync fails on staging from missing file)
• fresh_zones alias to fresh_zones_v201907,
  • Production: present, does not sync
  • Staging: missing
  • Best guess at correct source: dcp_fresh_zones
• waterfront_access_plan alias to waterfront_access_plan_v201902,
  • Production: present, does not sync
  • Staging: present, does not sync
  • Best guess at correct source: dcp_waterfront_access_plan
• coastal_zone_boundary alias to coastal_zone_boundary_v201601,
  • Production: present, does not sync
  • Staging: missing
  • Best guess at correct source: dcp_coastal_zone_boundary
• lower_density_growth_management_areas alias to lower_density_growth_management_areas_v201709,
  • Production: present, does not sync
  • Staging: missing
  • Best guess at correct source: dcp_lower_density_growth_management_areas (though sync fails on staging from download error)
• floodplain_firm2007 alias to floodplain_firm2007_v0,
  • Production: present, does not sync
  • Staging: missing
  • Best guess at correct source: production is correct and staging should get its own copy
• floodplain_pfirm2015 alias to floodplain_pfirm2015_v0,
  • Production: present, does not sync
  • Staging: missing
  • Best guess at correct source: production is correct and staging should get its own copy
• mandatory_inclusionary_housing alias to mandatory_inclusionary_housing_v202012
  • Production: present, does not sync
  • Staging: missing
  • Best guess at correct source: dcp_mandatory_inclusionary_housing
• e_designations alias to e_designations_v202012,
  • Production: present, does not sync
  • Staging: missing
  • Best guess at correct source: dcp_e_designations
• upland_waterfront_areas alias to upland_waterfront_areas_v200912,
  • Production: present, does not sync
  • Staging: missing
  • Best guess at correct source: source as configured
• transitzones alias to transitzones_v201902
  • legacy from before city of yes
  • source has been refactored to: dcp_appendixi_transit_zones
  • reference ticket: Refactor source data for CHO Layers labs-layers-api#346
• appendixj_designated_mdistricts alias to appendixj_designated_mdistricts_v201712,
  • Production: present, does not sync
  • Staging: missing
  • Best guess at correct source: dcp_appendixj_designated_mdistricts
• mta_rail_station_50ft_buffers alias to NA,
  • Production: present, does not sync
  • Staging: present, does not sync
  • Best guess at correct source: source as configured

The file app/components/intersecting-layers.js contains the sql request to carto and the table it references for tax lots.

The table it references for tax lots is dcp_mappluto.

• Production: present, syncs
• Staging: present, syncs
• Best guess at correct source: source as configured

Acceptance criteria

• inclusionary_housing is changed to dcp_inclusionary_housing in zola
• dcp_inclusionary_housing syncing is fixed in carto staging
• fresh_zones is changed to dcp_fresh_zones in zola
• waterfront_access_plan is changed to dcp_waterfront_access_plan in zola
• coastal_zone_boundary is changed to dcp_coastal_zone_boundary in zola
• lower_density_growth_management_areas is changed to dcp_lower_density_growth_management_areas in zola
• dcp_lower_density_growth_management_areas syncing is fixed in carto staging
• floodplain_firm2007_v0 with alias floodplain_firm2007 is added to carto staging
• floodplain_pfirm2015_v0 with alias floodplain_pfirm2015 is added to carto staging
• mandatory_inclusionary_housing is changed to dcp_mandatory_inclusionary_housing in zola
• e_designations is changed to dcp_e_designations in zola
• transitzones is changed to dcp_appendixi_transit_zones in zola
  • Note we may want to change the language around this layer, or replace it entirely with City of Yes layers. If we do, it will be part of Use City of Yes transit layers for intersection logic #1296
• follow up on "appendixi" data being different between Carto staging and production
• appendixj_designated_mdistricts is changed to dcp_appendixj_designated_mdistricts in zola

[TangoYankee]

Blocked by need for guidance on transit zones

Breaking transit zones into its own ticket: #1296

[TylerMatteo]

@TylerMatteo to flag with Matt on 12/30

[TylerMatteo]

@TangoYankee I flagged this issue with Matt and told him we would likely need GIS to confirm which tables we should switch to. How would you like to proceed?

[TangoYankee]

I'll send an email to the GIS DL with a list of tables

[caseysmithpgh]

Thanks @TangoYankee, this a helpful rundown.

• I agree with the table changes listed above (i.e. inclusionary_housing to dcp_inclusionary_housing, etc.),
  • Q: For those that need to be switched to the correct table, is staging missing for the current table or the table that it will be changed to?
• Will circle up with matt to fix sync for dcp_lower_density_growth_management_areas
• Defer to AE/Matt/Transportation on Transit Zone legacy issue
• Not familiar with digital ocean source location for mta_rail_station_50ft_buffers, floodplain_firm2007 or floodplain_pfirm2015. Perhaps you or Matt (untaggable, you were right!) can tell me where those live if they originate from DO.

I'm not familiar with managing the carto sync--so I plan to collaborate with Matt once he's back in office. Just so I understand, the tables that are stable (don't need to be changed) are definitely not syncing as expected. Do we know whether the sync for the tables we are switching to (i.e. dcp_inclusionary_housing) are currently working?

Did I miss anything?

[TangoYankee]

@caseysmithpgh Thank you for looking this over. I will start working on these layers in ZoLa and that should help me answer your questions

[TangoYankee]

I checked on staging dcp_inclusionary_housing at the file looked good in DO. As it's just Staging, I figured I would just try hitting "sync now" and it worked. I think it failed some unknown time and Carto stopped trying. It looks like it restarted the daily auto-sync, too

[TangoYankee]

Syncing on dcp_lower_density_growth_management_areas also fixed by clicking the button

[TangoYankee]

It appears "dcp_appendixi_transit_zones" data is different between staging and production

[caseysmithpgh]

It appears "dcp_appendixi_transit_zones" data is different between staging and production

uhoh, need to check with matt on this one because he published the latest. This is appendix i aka the old ones right?

[TangoYankee]

uhoh, need to check with matt on this one because he published the latest. This is appendix i aka the old ones right?

I should clarify. Carto staging and production appear different. DO staging and production appear to be the same. The timestamps in Carto make it appear that Carto production is correct. Carto staging is likely the one that should be updated

But yes, they are the old transitzones