test: fixing broken maxSteps tests, removing icons.test

Author: gureckis

src/core/config.js

@@ -40,7 +40,7 @@ function parseWidthHeight(value) {
  * @property {boolean} autoSave - Whether to auto-save data
  * @property {number} maxWrites - Maximum number of writes allowed
  * @property {number} minWriteInterval - Minimum interval between writes
- * @property {number}maxSteps - Maximum rows in stepper tables
+ * @property {number} maxSteps - Maximum rows in stepper tables
  * @property {string} randomSeed - Seed for random number generation
  * @property {string} deployURL - URL where app is deployed
  * @property {string} labURL - URL of the lab website

src/core/stepper/Stepper.js

@@ -181,13 +181,9 @@ export class Stepper extends StepState {
     const itemsToAdd = Array.isArray(items) ? items : [items]
 
     // Check if adding these items would exceed maxSteps
-    if (this._states.length + itemsToAdd.length > config.maxStepperRows) {
-      this._log.error(
-        `Cannot append ${itemsToAdd.length} rows as it exceeds the safety limit of ${config.maxStepperRows}`
-      )
-      throw new Error(
-        `Cannot append ${itemsToAdd.length} rows as it exceeds the safety limit of ${config.maxStepperRows}`
-      )
+    if (this._states.length + itemsToAdd.length > config.maxSteps) {
+      this._log.error(`Cannot append ${itemsToAdd.length} rows as it exceeds the safety limit of ${config.maxSteps}`)
+      throw new Error(`Cannot append ${itemsToAdd.length} rows as it exceeds the safety limit of ${config.maxSteps}`)
     }
 
     // Try to add each item individually
@@ -233,9 +229,9 @@ export class Stepper extends StepState {
     const totalCombinations = processedColumns.reduce((total, [_, arr]) => total * arr.length, 1)
 
     // Check if adding these combinations would exceed maxSteps
-    if (this._states.length + totalCombinations > config.maxStepperRows) {
+    if (this._states.length + totalCombinations > config.maxSteps) {
       throw new Error(
-        `Cannot create ${totalCombinations} combinations: would exceed maximum of ${config.maxStepperRows} rows`
+        `Cannot create ${totalCombinations} combinations: would exceed maximum of ${config.maxSteps} rows`
       )
     }
 
@@ -314,8 +310,8 @@ export class Stepper extends StepState {
     const maxLength = Math.max(...processedColumns.map(([_, arr]) => arr.length))
 
     // Check if adding these combinations would exceed maxSteps
-    if (this._states.length + maxLength > config.maxStepperRows) {
-      throw new Error(`Cannot create ${maxLength} combinations: would exceed maximum of ${config.maxStepperRows} rows`)
+    if (this._states.length + maxLength > config.maxSteps) {
+      throw new Error(`Cannot create ${maxLength} combinations: would exceed maximum of ${config.maxSteps} rows`)
     }
 
     // Check if any column has a different length

tests/vitest/core/stepper/Stepper.test.js

@@ -286,7 +286,7 @@ describe('Stepper test', () => {
     })
 
     it('should throw error when appending would exceed safety limit', () => {
-      const maxRows = Number(config.maxStepperRows)
+      const maxRows = Number(config.maxSteps)
       const items = Array(maxRows + 1).fill({ color: 'red', shape: 'circle' })
       expect(() => {
         stepper.append(items)
@@ -338,7 +338,7 @@ describe('Stepper test', () => {
     })
 
     it('should throw error when outer would exceed safety limit', () => {
-      const maxRows = Number(config.maxStepperRows)
+      const maxRows = Number(config.maxSteps)
       // Create arrays that would generate more combinations than maxSteps
       const trials = {
         x: Array(100).fill('x'),
@@ -865,7 +865,7 @@ describe('Stepper test', () => {
     })
 
     it('should throw error when zip would exceed safety limit', () => {
-      const maxRows = Number(config.maxStepperRows)
+      const maxRows = Number(config.maxSteps)
 
       // Create arrays that would exceed the limit when zipped
       const trials = {