Fix role permissions update silently failing with many maps

getFormParams() submitted every checkbox unconditionally — checked as "1"
and unchecked as "". With 328 maps x 3 permission checkboxes = 984 POST
vars, plus the other form fields, PHP's default max_input_vars=1000 limit
is exceeded. PHP silently truncates $_POST at that point. The submit button
(_submit) is rendered after all permission checkboxes and gets dropped,
causing submitted() to return false and is_action() to return false —
resulting in the form appearing to do nothing with no error shown.

Fix by not submitting unchecked checkboxes at all, matching standard HTML
form behaviour. get_checkbox() already returns false for both absent keys
and empty strings, and updateRolePerms() deletes all existing permissions
before re-inserting the checked ones, so the behaviour is identical.

Author: loocars

changelog.d/fix-role-perms-max-input-vars.md

@@ -0,0 +1 @@
+FIX: Updating role permissions silently fails when there are many maps due to PHP max_input_vars limit being exceeded

share/frontend/nagvis-js/js/ajax.js

@@ -194,9 +194,10 @@ function getFormParams(formId, skipHelperFields) {
         } else if (aFields[i].type == "checkbox") {
             if (aFields[i].checked) {
                 add_data(aFields[i].name, aFields[i].value);
-            } else {
-                add_data(aFields[i].name, "");
             }
+            // Unchecked checkboxes are intentionally not submitted, matching standard
+            // HTML form behaviour. This prevents hitting PHP's max_input_vars limit
+            // on forms with many checkboxes (e.g. role permissions with many maps).
         } else if (aFields[i].type == "radio") {
             if (aFields[i].checked) {
                 add_data(aFields[i].name, aFields[i].value);