FIX: Keep bracketed strings in service descriptions in hover menu

The dynamic macro pass in ElementHover.js runs over the whole template
after the child rows have been substituted, so a bracketed string that is
part of a child value (e.g. a service description like "Switch1 [xxx]") was
mistaken for an unknown macro and dropped, leaving only "Switch1".

Preserve the original "[name]" text for tokens that are not actual macros,
using hasOwnProperty so that defined macros holding a legitimately empty
value (e.g. an empty plugin output) are still replaced correctly.

Author: loocars

changelog.d/fix-hover-bracket-macro.md

@@ -0,0 +1 @@
+FIX: Hover menu no longer strips bracketed strings (e.g. "[xxx]") from service descriptions

share/frontend/nagvis-js/js/ElementHover.js

@@ -562,9 +562,14 @@ const ElementHover = Element.extend({
         if (this.obj.conf.hover_childs_show && this.obj.conf.hover_childs_show == "1")
             template_html = this.replaceChildMacros(template_html);
 
-        // Replace all normal macros
-        template_html = template_html.replace(/\[(\w*)\]/g, function () {
-            return oMacros[arguments[1]] || "";
+        // Replace all normal macros. This pass also runs over the already
+        // substituted child rows, so a bracketed string that is part of a
+        // child value (e.g. a service description like "Switch1 [xxx]") must
+        // not be mistaken for an unknown macro and dropped. Keep the original
+        // "[name]" text for tokens that are not actual macros, while still
+        // replacing defined macros that legitimately hold an empty value.
+        template_html = template_html.replace(/\[(\w*)\]/g, function (match, name) {
+            return Object.prototype.hasOwnProperty.call(oMacros, name) ? oMacros[name] : match;
         });
         return template_html;
     },