Skip to content
This repository was archived by the owner on Jan 24, 2021. It is now read-only.
This repository was archived by the owner on Jan 24, 2021. It is now read-only.

Should ConfigureAwait(false) be called in NancyHost? #2471

@xt0rted

Description

@xt0rted

While looking through the code and using the ReSharper ConfigureAwait Checker plugin I came across Nancy.Hosting.Self/NancyHost.cs#L133-134.

Should line 133 and/or 134 call .ConfigureAwait(false)? The other warning I'm getting is on line 134 because it's not awaited but I wasn't sure if that should be or not.

Those are the only two spots outside of the test projects that don't call ConfigureAwait.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions