RequestStream cause a deadlock

[delarocka]

Prerequisites

• I have written a descriptive issue title
• I have verified that I am running the latest version of Nancy
• I have verified if the problem exist in both DEBUG and RELEASE mode
• I have searched open and closed issues to ensure it has not already been reported

Description

I got an application running on OWIN self hosting. During load testing application suffers a deadlock (most threads are in waiting state), causing by RequestStream's MoveToWritableStream method.

Steps to Reproduce

NancySelfHost.zip contains simplified project and JMeter test (SummonDeadlock.jmx) that i use for load test. Just build and run project and run JMeter test.

System Configuration

• Nancy version: 1.4.4
• Nancy host
  • ASP.NET
  • OWIN
  • Self-Hosted
  • Other:
• Other Nancy packages and versions: Nancy.Owin 1.4.1
• Environment (Operating system, version and so on): Windows 10 10.0.15063
• .NET Framework version: 4.5.2
• Additional information: JMeter version 3.2, i used a separate machine to run JMeter.

[xt0rted]

I think this is what #2686 fixed but was never backported to 1.4. Are you able to try the pre-release of 2.0 to confirm if you still have the issue?

[delarocka]

I tried to backport #2686 to 1.x branch and can confirm it fixes the issue.

[thecodejunkie]

Resolved by #2686