feat(review): implement review command argument parsing and tests

Author: soumojit-D48

source/cli.spec.ts

@@ -575,178 +575,6 @@ test('resume flags: --continue without `run` is not a non-interactive error', t
 	t.false(nonInteractiveError);
 });
 
-// Review command parsing tests. Mirrors the review arg parsing in cli.tsx:
-// `nanocoder review <target>` injects `/review <target>` as the prompt.
-
-type ReviewParseResult = {
-	prompt: string | undefined;
-	error: boolean;
-};
-
-function parseReviewArgs(args: string[]): ReviewParseResult {
-	const isReviewCommand = args[0] === 'review';
-	if (!isReviewCommand) {
-		return {prompt: undefined, error: false};
-	}
-	const afterReviewArgs = args.slice(1);
-	const reviewArgs: string[] = [];
-	for (let i = 0; i < afterReviewArgs.length; i++) {
-		const arg = afterReviewArgs[i];
-		if (
-			arg === '--vscode' ||
-			arg === '--json' ||
-			arg === '--trust-directory' ||
-			arg === '--plain' ||
-			arg === '--no-plain' ||
-			arg === '--no-alt-screen' ||
-			arg === '--alt-screen'
-		) {
-			continue;
-		} else if (
-			arg === '--vscode-port' ||
-			arg === '--provider' ||
-			arg === '--model' ||
-			arg === '--context-max' ||
-			arg === '--output-format'
-		) {
-			i++; // skip this flag and its value
-			continue;
-		} else if (arg === '--mode') {
-			i++; // skip this flag and its value
-			continue;
-		} else if (arg.startsWith('--mode=')) {
-			continue;
-		} else if (arg.startsWith('--output-format=')) {
-			continue;
-		} else {
-			reviewArgs.push(arg);
-		}
-	}
-	if (reviewArgs.length === 0) {
-		return {prompt: '/review', error: false};
-	}
-	return {prompt: `/review ${reviewArgs[0]}`, error: false};
-}
-
-test('review CLI: parses review with branch name', t => {
-	const result = parseReviewArgs(['review', 'feature/auth']);
-	t.is(result.prompt, '/review feature/auth');
-	t.false(result.error);
-});
-
-test('review CLI: parses review with PR number', t => {
-	const result = parseReviewArgs(['review', '42']);
-	t.is(result.prompt, '/review 42');
-	t.false(result.error);
-});
-
-test('review CLI: no args produces /review', t => {
-	const result = parseReviewArgs(['review']);
-	t.is(result.prompt, '/review');
-	t.false(result.error);
-});
-
-test('review CLI: returns undefined when not a review command', t => {
-	const result = parseReviewArgs(['run', 'hello']);
-	t.is(result.prompt, undefined);
-	t.false(result.error);
-});
-
-test('review CLI: anchors on args[0], not findIndex', t => {
-	const result = parseReviewArgs(['--vscode', 'review', 'main']);
-	t.is(result.prompt, undefined);
-	t.false(result.error);
-});
-
-test('review CLI: filters --vscode flag', t => {
-	const result = parseReviewArgs(['review', 'main', '--vscode']);
-	t.is(result.prompt, '/review main');
-});
-
-test('review CLI: filters --provider flag and value', t => {
-	const result = parseReviewArgs([
-		'review',
-		'main',
-		'--provider',
-		'openrouter',
-	]);
-	t.is(result.prompt, '/review main');
-});
-
-test('review CLI: filters --model flag and value', t => {
-	const result = parseReviewArgs(['review', 'main', '--model', 'gpt-4']);
-	t.is(result.prompt, '/review main');
-});
-
-test('review CLI: filters --mode flag and value (two-token)', t => {
-	const result = parseReviewArgs(['review', 'main', '--mode', 'plan']);
-	t.is(result.prompt, '/review main');
-});
-
-test('review CLI: filters --mode fused form', t => {
-	const result = parseReviewArgs(['review', 'main', '--mode=plan']);
-	t.is(result.prompt, '/review main');
-});
-
-test('review CLI: filters --json flag', t => {
-	const result = parseReviewArgs(['review', 'main', '--json']);
-	t.is(result.prompt, '/review main');
-});
-
-test('review CLI: filters --output-format flag and value', t => {
-	const result = parseReviewArgs([
-		'review',
-		'main',
-		'--output-format',
-		'json',
-	]);
-	t.is(result.prompt, '/review main');
-});
-
-test('review CLI: filters --context-max flag and value', t => {
-	const result = parseReviewArgs([
-		'review',
-		'main',
-		'--context-max',
-		'128k',
-	]);
-	t.is(result.prompt, '/review main');
-});
-
-test('review CLI: filters --plain and --no-plain flags', t => {
-	const result1 = parseReviewArgs(['review', 'main', '--plain']);
-	t.is(result1.prompt, '/review main');
-
-	const result2 = parseReviewArgs(['review', 'main', '--no-plain']);
-	t.is(result2.prompt, '/review main');
-});
-
-test('review CLI: filters --no-alt-screen and --alt-screen flags', t => {
-	const result1 = parseReviewArgs(['review', 'main', '--no-alt-screen']);
-	t.is(result1.prompt, '/review main');
-
-	const result2 = parseReviewArgs(['review', 'main', '--alt-screen']);
-	t.is(result2.prompt, '/review main');
-});
-
-test('review CLI: filters --trust-directory flag', t => {
-	const result = parseReviewArgs(['review', 'main', '--trust-directory']);
-	t.is(result.prompt, '/review main');
-});
-
-test('review CLI: handles multiple mixed flags', t => {
-	const result = parseReviewArgs([
-		'review',
-		'feature',
-		'--provider',
-		'ollama',
-		'--mode',
-		'plan',
-		'--json',
-	]);
-	t.is(result.prompt, '/review feature');
-});
-
 // Run command with flags before 'run' (the blocker fix)
 test('CLI parsing: handles flags before run command', t => {
 	const args = ['--plain', 'run', 'say', 'hi'];
@@ -765,9 +593,3 @@ test('CLI parsing: handles --mode before run command', t => {
 	const prompt = parsePrompt(args);
 	t.is(prompt, 'audit module');
 });
-
-// Review should only use first arg, not join all
-test('review CLI: only uses first positional arg', t => {
-	const result = parseReviewArgs(['review', 'feature', 'extra', 'args']);
-	t.is(result.prompt, '/review feature');
-});

source/cli.tsx

@@ -199,6 +199,8 @@ async function main(): Promise<void> {
 	// Those packages pull ~thousand+ modules; --acp / --plain / auth must stay
 	// on the lightweight path. Ink + App load only in the final TUI branch.
 
+	const {parseReviewCliArgs} = await import('./commands/review-cli');
+
 	const vscodeMode = args.includes('--vscode');
 
 	// Extract VS Code port if specified
@@ -371,52 +373,10 @@ async function main(): Promise<void> {
 	// `nanocoder run /review <target>`. The target is the branch or PR number
 	// to review. Flags between `review` and the target are filtered the same
 	// way as `run`.
-	const isReviewCommand = args[0] === 'review';
+	const {isReviewCommand, prompt: reviewPrompt} = parseReviewCliArgs(args);
 	if (isReviewCommand) {
-		const afterReviewArgs = args.slice(1);
-		const reviewArgs: string[] = [];
-		for (let i = 0; i < afterReviewArgs.length; i++) {
-			const arg = afterReviewArgs[i];
-			if (
-				arg === '--vscode' ||
-				arg === '--json' ||
-				arg === '--trust-directory' ||
-				arg === '--plain' ||
-				arg === '--no-plain' ||
-				arg === '--no-alt-screen' ||
-				arg === '--alt-screen'
-			) {
-				continue;
-			} else if (
-				arg === '--vscode-port' ||
-				arg === '--provider' ||
-				arg === '--model' ||
-				arg === '--context-max' ||
-				arg === '--output-format'
-			) {
-				i++; // skip this flag and its value
-				continue;
-			} else if (arg === '--mode') {
-				i++; // skip this flag and its value
-				continue;
-			} else if (arg.startsWith('--mode=')) {
-				continue;
-			} else if (arg.startsWith('--output-format=')) {
-				continue;
-			} else {
-				reviewArgs.push(arg);
-			}
-		}
-		if (reviewArgs.length === 0) {
-			// No target provided — review current branch against default.
-			// This matches the /review behavior in the interactive TUI.
-			nonInteractivePrompt = '/review';
-			nonInteractiveMode = true;
-		} else {
-			// Inject as a slash command prompt.
-			nonInteractivePrompt = `/review ${reviewArgs[0]}`;
-			nonInteractiveMode = true;
-		}
+		nonInteractivePrompt = reviewPrompt;
+		nonInteractiveMode = true;
 	}
 
 	// --continue/-c and --resume/-r: session resume flags for the interactive