Skip to content

Commit 82116a8

Browse files
committed
fix: restore /status default-branch marker and clear knip 6.33 findings
Two independent failures landed on main between 17:45 and 18:04 UTC and broke every PR opened from that base. Adding the git branch to the boot summary dropped the `isDefault` case from the shared `formatGitStatusSummary` so the boot summary could render a bare `⎇ main`. The /status panel reads the same helper, so it lost its `(default)` marker too and `status.spec.tsx` started failing. The shared helper reports every marker again; the boot summary now drops the `default` marker itself, which is the only place the shorter label was wanted. Bumping knip 6.24.0 -> 6.33.0 surfaced 25 type re-exports that no longer resolve through their barrels. Every consumer already imports these types from the defining module, so the pass-through lines are removed rather than ignored. The types themselves are untouched.
1 parent af0ae10 commit 82116a8

10 files changed

Lines changed: 14 additions & 32 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@nanocollective/nanocoder": patch
3+
---
4+
5+
Restored the `(default)` marker on the `/status` panel's Git line. Adding the git branch to the boot summary removed the `isDefault` case from the shared `formatGitStatusSummary` helper so the boot summary could render a bare `⎇ main`, but `/status` reads the same helper and silently lost its marker too. The shared helper reports every marker again and the boot summary drops the `default` one itself, which is the only place the shorter label was wanted.

source/app/components/app-container.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@ import {homeRelative} from '@/utils/path';
1717
*/
1818
export function formatBootSummaryGitLabel(status: GitStatusSummary): string {
1919
const {branch, marker} = formatGitStatusSummary(status);
20-
return marker ? `⎇ ${branch} (${marker})` : `⎇ ${branch}`;
20+
// The boot summary shares one line with provider/model/config, so only the
21+
// detached marker earns its width here. Being on the default branch is the
22+
// common case and stays unmarked; the /status panel shows every marker.
23+
if (!marker || marker === 'default') return `⎇ ${branch}`;
24+
return `⎇ ${branch} (${marker})`;
2125
}
2226

2327
export interface AppContainerProps {

source/app/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
// Re-export the main App component and types
1+
// Re-export the main App component
22
export {default} from './App';
3-
export type {AppProps} from './types';
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
export type {JsonFlatRow, JsonKind, JsonNode} from './json-tree';
2-
export type {JsonViewerProps} from './json-viewer';
31
export {JsonViewer} from './json-viewer';

source/hooks/chat-handler/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,5 @@
55
* handling streaming responses, tool calls, and conversation state.
66
*/
77

8-
// Types
9-
export type {ChatHandlerReturn, UseChatHandlerProps} from './types';
108
// Main hook
119
export {useChatHandler} from './useChatHandler';

source/lsp/index.ts

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,25 +7,6 @@
77
* - Diagnostics, completions, code actions, and formatting
88
*/
99

10-
export {type LSPServerConfig} from './lsp-client';
10+
export {getLSPManager, type LSPInitResult} from './lsp-manager';
1111

12-
export {
13-
type DiagnosticsResult,
14-
getLSPManager,
15-
type LSPInitResult,
16-
type LSPManagerConfig,
17-
} from './lsp-manager';
18-
19-
export {
20-
type CodeAction,
21-
type CompletionItem,
22-
type Diagnostic,
23-
DiagnosticSeverity,
24-
type FormattingOptions,
25-
type Location,
26-
type Position,
27-
type PublishDiagnosticsParams,
28-
type Range,
29-
type TextEdit,
30-
type WorkspaceEdit,
31-
} from './protocol';
12+
export {DiagnosticSeverity} from './protocol';

source/skills/bootstrap.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,5 +281,3 @@ function detectDeprecations(projectRoot: string): string[] {
281281
}
282282
return warnings;
283283
}
284-
285-
export type {SkillCollision};

source/tools/git/utils.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,7 @@ export function formatGitStatusSummary(status: GitStatusSummary): {
250250
marker: string | null;
251251
} {
252252
if (status.detached) return {branch: status.branch, marker: 'detached'};
253+
if (status.isDefault) return {branch: status.branch, marker: 'default'};
253254
return {branch: status.branch, marker: null};
254255
}
255256

source/tools/tasks/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
export type {Task, TaskStatus} from './types';
21
export {writeTasksTool} from './write-tasks';

source/utils/shutdown/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,3 @@ export {
55
/** @internal */
66
ShutdownManager,
77
} from './shutdown-manager';
8-
export type {ShutdownHandler, ShutdownManagerOptions} from './types';

0 commit comments

Comments
 (0)