Commit a72f197
fix(nc-review): render findings as blocks, not a table
Findings run to a paragraph or more. A table cell forces all of that onto one
line with newlines collapsed, squeezed into a narrow column — run 7's single
finding was a 200-word cell and effectively unreadable.
Each finding is now its own block: a bold heading carrying severity, area and
location, then the detail at full width. Findings are sorted blocking first,
then important, then nit, so the thing that matters is at the top rather than
wherever the model happened to emit it.
This also removes a constraint rather than just moving markup around. The table
required gsub("\n"; " ") on every detail, so the agent could never quote code.
It can now, and the rubric says so with an example — for a finding like "this
captured reference is never used", quoting the two offending lines makes the
point faster than any description of them.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PZY52ePXLjwG9TaQgq2cHT1 parent 3a77f12 commit a72f197
2 files changed
Lines changed: 29 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
276 | 286 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
483 | 483 | | |
484 | 484 | | |
485 | 485 | | |
486 | | - | |
487 | | - | |
488 | | - | |
489 | | - | |
490 | | - | |
491 | | - | |
492 | | - | |
493 | | - | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
494 | 505 | | |
495 | 506 | | |
496 | 507 | | |
| |||
0 commit comments