Commit f70efb5
feat(nc-review): mention the author, and track what a re-review fixed
Two changes.
Mention the PR author, so the review reaches them instead of waiting to be
noticed. Bots are skipped — dependabot and github-actions cannot read a review
and an @-mention on every dependency bump is noise. Detection uses the API's
is_bot rather than matching a "[bot]" suffix, which would miss accounts that do
not follow the convention.
Feed the previous verdict back in on /re-review. Without it the agent re-derives
every finding from scratch and re-files ones the author has already fixed, which
is worse than not re-reviewing at all: it tells someone their work did not land.
The most recent nc-review comment is now included in the context, with
instructions to sort each prior point into resolved / not resolved / cannot
tell, and a new `addressed` array in the schema.
Fixed points are rendered as an explicit "Addressed since the last review"
block rather than silently dropped. Absence is ambiguous — from the author's
side it reads as the bot forgetting rather than the work landing.
The rubric also says plainly that re-raising a fixed point is the fastest way to
make people stop reading the reviews, and that a fix can introduce a new problem
which is a new finding like any other.
Verified by extracting the real Post review step and running it against three
cases: a re-review with three addressed items and one remaining finding, a bot
author (no mention emitted), and a first review with no `addressed` field (no
empty block).
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PZY52ePXLjwG9TaQgq2cHT1 parent 82079ba commit f70efb5
2 files changed
Lines changed: 92 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
238 | 238 | | |
239 | 239 | | |
240 | 240 | | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
241 | 263 | | |
242 | 264 | | |
243 | 265 | | |
| |||
262 | 284 | | |
263 | 285 | | |
264 | 286 | | |
265 | | - | |
| 287 | + | |
| 288 | + | |
266 | 289 | | |
267 | 290 | | |
268 | 291 | | |
| |||
284 | 307 | | |
285 | 308 | | |
286 | 309 | | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
179 | 191 | | |
180 | 192 | | |
181 | 193 | | |
| |||
246 | 258 | | |
247 | 259 | | |
248 | 260 | | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
249 | 284 | | |
250 | 285 | | |
251 | 286 | | |
| |||
440 | 475 | | |
441 | 476 | | |
442 | 477 | | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
443 | 490 | | |
444 | 491 | | |
445 | 492 | | |
| |||
493 | 540 | | |
494 | 541 | | |
495 | 542 | | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
496 | 551 | | |
497 | 552 | | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
498 | 563 | | |
499 | 564 | | |
500 | 565 | | |
| |||
0 commit comments